1033451 - [Smart Collection] Adding collection to top is slow to draw and load

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect, P1)

Description

[Tony Chung [:tchung]]

See screenshot.   when trying to long tap and move a smart collection to the top of your collections, the screen is slow to redraw, icons dissapear and reappear, and the perceived performance is overall laggy. 

See screencast: http://youtu.be/t-PRY3pYodU

1) install 2.0 build on flame

Gaia      3bfe47c58c959c42f5ffe0309b5380ea514ccd69
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/f40e767ea283
BuildID   20140702000201
Version   32.0a2
ro.build.version.incremental=109
ro.build.date=Mon Jun 16 16:51:29 CST 2014
B1TC00011220

2) on homescreen, long tap and add a smart collection  (ie. custom -- "porsche")
3) open that collection, and scroll down, and long tap on any of the collection
4) click "Add to Top of collection"
5) Verify it is slow to add, with icons disappearing for a second, and laggy loading. 

Expected:
- moving the smart collection site to the top should feel faster, comparing to a baseline of how we move apps on the homescreen

Actual:
- performance is slower

Comment 1

[Jason Smith [:jsmith]]

Definitely looks ugly. UX - Is this a blocker from your perspective?

Comment 2

[Stephany Wilkes]

Unfortunately, since it involves homescreen, I think we have to block on this one. I saw this at varying levels yesterday during the bug bash: sometimes it was very slow, sometimes barely noticeable. But I think we have to block. Sorry!

Comment 3

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Comment 5

[Kevin Grandon :kgrandon]

Comment on attachment 8450654 [details] [review]
Github pull request

Hey Cristian - could you review these performance improvements to smart collections while the E.me guys are on PTO? Thanks!

Comment 6

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8450654 [details] [review]
Github pull request

Amazing good job! I tested it on my device and it is very fast now!! Ans I didn't  find any regression. Thanks a lot

Comment 7

[Kevin Grandon :kgrandon]

Master: https://github.com/mozilla-b2g/gaia/commit/bff35131b7eba7b4d05536313b99f82915423a39

Comment 8

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/dd5cf2b27b242753512abd8086cbf10560ddaa59

Comment 9

[Shally Li（leave from Mozilla）]

This issue has been successfully verified on Flame v2.1&2.0.
See attachment: verified_v2.1.mp4
Reproduce rate: 0/5

STR:
1. On homescreen, long tap and add a smart collection  (ie. custom -- "porsche")
2. Open the collection, and scroll down, and long tap on any of the collection.
4. Click "Add to Top of collection".
5. Verify it is slow to add, with icons disappearing for a second, and laggy loading. 
**Moving the smart collection site to the top is fast, comparing to a baseline of how we move apps on the homescreen.

Flame 2.1 build:
Gaia-Rev        5655269098c7e82254e56933f1af05b4abe2a2f3
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/86608c9389b5
Build-ID        20141204001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141204.034958
FW-Date         Thu Dec  4 03:50:09 EST 2014
Bootloader      L1TC00011880

Flame 2.0 build:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/ff1100ba2ab8
Build-ID        20141204000228
Version         32.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141204.040425
FW-Date         Thu Dec  4 04:04:36 EST 2014
Bootloader      L1TC00011880

Comment 10

[Shally Li（leave from Mozilla）]

Attachment: verified_v2.1.MP4