1033489 - Mirrored reviews and comments should provide links back to Review Board

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect)

Description

[Steven MacLeod [:smacleod]]

Right now we mirror the content of a review/comment, but don't provide a nice way to find it on Review Board. It should be pretty easy to generate links to the specific review/comment and add it to the Bugzilla comment.

Comment 1

[Mark Côté [:mcote]]

Just want to comment that this isn't a blocker for initial release, since at least we have a link to the squashed review as an attachment.  Definitely very nice to have though.

Comment 2

[(no longer active)]

If this is easy to fix, it would be awesome if we can fix it before the initial release.  See the confusion happened in bug 1054112, for example!

Comment 3

[Steven MacLeod [:smacleod]]

I agree. I should have enough time to take care of this along with the other blockers.

Comment 4

[Mark Côté [:mcote]]

Attachment: Review for review ID: bz://1033489/mcote

/r/135 - Bug 1033489 - Include link to review in Bugzilla comment.

Pull down this commit:

hg pull review -r 0f9e85b863cb0d8be25f7330a995ed87955f96db

Comment 5

[Mark Côté [:mcote]]

Comment on attachment 8483189 [details]
Review for review ID: bz://1033489/mcote

/r/135 - Bug 1033489 - Include link to review in Bugzilla comment.

Pull down this commit:

hg pull review -r 8bf3ec59f6e92b1f9e3f49403c6743c0144d6974

Comment 6

[Mark Côté [:mcote]]

I updated this patch to work around bug 508541 as per bug 1021929 comment 4.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

::: pylib/rbbz/rbbz/diffs.py
(Diff revision 2)
> -    review_text = []
> +    review_text = [url]

Do you have an example comment in Bugzilla-dev where a comment like this has been posted that I can look at?

Just in terms of formatting, I wonder if it'd be good to add more newlines after the URL.

Comment 8

[Mark Côté [:mcote]]

Attachment: Screen shot of review comments with links

I've been using my own local BMO instance, but here's a screenshot of a review comment and a simple "Ship It".

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Ship It!

Comment 10

[Mark Côté [:mcote]]

http://hg.mozilla.org/hgcustom/version-control-tools/rev/f523bda3ad7b