1033687 - [Flatfish] v1.4 build fails in GonkGPSGeolocationProvider.cpp

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[Ralph Giles (:rillian)]

$ git clone https://github.com/mozilla-b2g/B2G.git b2g_flatfish
$ cd b2g_flatfish
$ BRANCH=v1.4 ./config.sh flatfish
$ B2G_UPDATER=1 ./build.sh gecko -j1

...

../../../../gecko/dom/system/gonk/GonkGPSGeolocationProvider.cpp: In static member function 'static void GonkGPSGeolocationProvider::LocationCallback(GpsLocation*)':
../../../../gecko/dom/system/gonk/GonkGPSGeolocationProvider.cpp:102:66: warning: 'visibility' attribute ignored [-Wattributes]
../../../../gecko/dom/system/gonk/GonkGPSGeolocationProvider.cpp: In static member function 'static void GonkGPSGeolocationProvider::SetCapabilitiesCallback(uint32_t)':
../../../../gecko/dom/system/gonk/GonkGPSGeolocationProvider.cpp:157:66: warning: 'visibility' attribute ignored [-Wattributes]
../../../../gecko/dom/system/gonk/GonkGPSGeolocationProvider.cpp: In member function 'void GonkGPSGeolocationProvider::StartGPS()':
../../../../gecko/dom/system/gonk/GonkGPSGeolocationProvider.cpp:600:8: warning: unused variable 'singleShot' [-Wunused-variable]
../../../../gecko/dom/system/gonk/GonkGPSGeolocationProvider.cpp: In member function 'virtual nsresult GonkGPSGeolocationProvider::Startup()':
../../../../gecko/dom/system/gonk/GonkGPSGeolocationProvider.cpp:732:54: error: 'RequestSettingValue' was not declared in this scope

In the directory  /data/giles/B2G/objdir-gecko/dom/system/gonk
The following command failed to execute properly:
/usr/bin/ccache /data/giles/B2G/prebuilts/gcc/linux-x86/arm/arm-linux-androideabi-4.6/bin/arm-linux-androideabi-g++ -o GonkGPSGeolocationProvider.o -c -fvisibility=hidden -DOS_POSIX=1 -DOS_LINUX=1 -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -DNO_NSPR_10_SUPPORT -I/data/giles/B2G/gecko/dom/system/gonk -I. -I/data/giles/B2G/gecko/ipc/chromium/src -I/data/giles/B2G/gecko/ipc/glue -I/data/giles/B2G/gecko/dom/base -I/data/giles/B2G/gecko/dom/bluetooth -I/data/giles/B2G/gecko/dom/events -I/data/giles/B2G/gecko/dom/nfc -I/data/giles/B2G/gecko/dom/src/geolocation -I/data/giles/B2G/gecko/dom/wifi -I/data/giles/B2G/objdir-gecko/ipc/ipdl/_ipdlheaders -I../../../dist/include -I/home/giles/data/B2G/objdir-gecko/dist/include/nspr -I/home/giles/data/B2G/objdir-gecko/dist/include/nss -I/home/giles/data/B2G/objdir-gecko/dist/include -fPIC -DANDROID -isystem /data/giles/B2G/bionic/libc/arch-arm/include -isystem /data/giles/B2G/bionic/libc/include/ -isystem /data/giles/B2G/bionic/libc/kernel/common -isystem /data/giles/B2G/bionic/libc/kernel/arch-arm -isystem /data/giles/B2G/bionic/libm/include -I/data/giles/B2G/system -I/data/giles/B2G/system/core/include -isystem /data/giles/B2G/bionic -I/data/giles/B2G/hardware/libhardware/include -I/data/giles/B2G/external/valgrind/fxos-include -I/data/giles/B2G/frameworks/native/include -I/data/giles/B2G/frameworks/av/include -I/data/giles/B2G/frameworks/av/include/media -I/data/giles/B2G/frameworks/av/include/camera -I/data/giles/B2G/frameworks/native/include/media/openmax -I/data/giles/B2G/frameworks/av/media/libstagefright/include -I/data/giles/B2G/external/dbus -I/data/giles/B2G/external/bluetooth/bluez/lib -DMOZILLA_CLIENT -include ../../../mozilla-config.h -MD -MP -MF .deps/GonkGPSGeolocationProvider.o.pp -DANDROID -isystem /data/giles/B2G/bionic/libc/arch-arm/include -isystem /data/giles/B2G/bionic/libc/include/ -isystem /data/giles/B2G/bionic/libc/kernel/common -isystem /data/giles/B2G/bionic/libc/kernel/arch-arm -isystem /data/giles/B2G/bionic/libm/include -I/data/giles/B2G/system -I/data/giles/B2G/system/core/include -isystem /data/giles/B2G/bionic -I/data/giles/B2G/hardware/libhardware/include -I/data/giles/B2G/external/valgrind/fxos-include -I/data/giles/B2G/frameworks/native/include -I/data/giles/B2G/frameworks/av/include -I/data/giles/B2G/frameworks/av/include/media -I/data/giles/B2G/frameworks/av/include/camera -I/data/giles/B2G/frameworks/native/include/media/openmax -I/data/giles/B2G/frameworks/av/media/libstagefright/include -I/data/giles/B2G/external/dbus -I/data/giles/B2G/external/bluetooth/bluez/lib -Wall -Wpointer-arith -Woverloaded-virtual -Werror=return-type -Werror=int-to-pointer-cast -Wtype-limits -Wempty-body -Wsign-compare -Wno-invalid-offsetof -mandroid -fno-short-enums -fno-exceptions -Wno-psabi -DMOZ_ENABLE_JS_DUMP -include /data/giles/B2G/gonk-misc/Unicode.h -I/data/giles/B2G/gecko/build/stlport/stlport -I/data/giles/B2G/ndk/sources/cxx-stl/system/include -march=armv7-a -mthumb -mfpu=neon -mfloat-abi=softfp -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -std=gnu++0x -pipe -DNDEBUG -DTRIMMED -g -Os -freorder-blocks -fno-reorder-functions -funwind-tables /data/giles/B2G/gecko/dom/system/gonk/GonkGPSGeolocationProvider.cpp
make[6]: *** [GonkGPSGeolocationProvider.o] Error 1
make[5]: *** [dom/system/gonk/compile] Error 2


gecko here is https://git.mozilla.org/releases/gecko.git
commit b3860ad136a96eb428a47e6747808ec8873ba519
aka B2G_1_4_20140609_MERGEDAY-262-gb3860ad

Comment 1

[Steve Lee]

Can confirm

It's a conditional compilation fail due to Flatfish turning off the RIL build

GonkGPSGeolocationProvider.cpp::RequestSettingValue
is defined #ifdef MOZ_B2G_RIL

but on lines 733 and 824 it is referenced in code not #ifdef MOZ_B2G_RIL 

I've not provided a patch as not familiar enough with the code to know of side effects of just adding #if defined() around those calls.

Comment 2

[Steve Lee]

On further thought the Flatfish does have GPS of some sort so perhaps the RIL should be enabled, or at least partially?

Also the build for 2.1 is fine so perhaps something did not get correctly merged across branches?

Comment 3

[Sherman Chen [:chens] (inactive)]

As described in comment 2, if this doesn't reproduce in master branch then suggest to close it.
Tablet contributor program should go with m-c branch and this will not have impact.

Comment 4

[Ralph Giles (:rillian)]

This in not an issue on master.

Comment 5

[Steve Lee]

OK, Asa stated TCP users should be on 2.1 (Master) anyway.
It does mean we don't have a stable build branch though.