1033858 - View error output during marionette_js runs

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Dale Harvey (:daleharvey)]

When running the integration test, VERBOSE=1 will output console.logs but not general gecko output (in particular error logs, like runtime errors and syntax errors)

I dont know of any way to access them, would vastly ease debugging tests

Comment 1

[Dale Harvey (:daleharvey)]

Am I missing something? or if not anyone wanna give me a little pointer to how to implement this?

Comment 2

[Gareth Aye [:gaye] (back from PTO)]

Hey Dale! Right now we listen to the console api via https://github.com/mozilla-b2g/marionette-js-logger/blob/master/lib/client.js#L422 and send stuff over a websocket to the node / cli-attached process. If you want to add more listening and message sending, it should be pretty straightforward and I would be happy to review.

Comment 3

[Dale Harvey (:daleharvey)]

Attachment: https://github.com/daleharvey/marionette-js-logger/commit/27c74a014f70a57191b473777929c7fa7729bf73

Previously with marionette failures, if there was a syntax / runtime error in content there was absolutely no indication, it just meant that the test would hang. We have a listener on the console events but none for errors in the content. Now we get: 

[marionette error] app://verticalhome.gaiamobile.org/js/app.js:70 SyntaxError: let is a reserved identifier

I havent figured out how to get stack traces, if the content generates a console.error then we will get them, but |nsIConsoleService| doesnt hold that information, I suggest we file a follow up and I will take a look as this alone makes life debugging a thousand times easier

Comment 4

[Dale Harvey (:daleharvey)]

Also I based this patch on top of the other (https://bugzilla.mozilla.org/show_bug.cgi?id=1037390)

Comment 5

[Dale Harvey (:daleharvey)]

Paul, do you have any suggestions on how to get and display the stack trace when I observe an error via |nsIConsoleService|? I had been pointed to Components.stack however if I simply access that inside the observe callback I dont get back much useful 

  { language: 0,
     languageName: 'C++',
     filename: null,
     name: null,
     lineNumber: 0,
     sourceLine: '',
     caller: null }

Comment 6

[Paul Rouget [:paul]]

Forwarding needinfo to Panos.

Comment 7

[Panos Astithas (he/him) [:past] (please ni?)]

You will need something like Console.jsm#getStack:

http://dxr.mozilla.org/mozilla-central/source/toolkit/devtools/Console.jsm#355

You should probably skip the frames that aren't JavaScript, which would have frame.language == 2:

https://developer.mozilla.org/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsIProgrammingLanguage

Comment 8

[Dale Harvey (:daleharvey)]

Attachment: https://github.com/mozilla-b2g/marionette-js-logger/pull/11

Added tests and rebased

Comment 9

[Dale Harvey (:daleharvey)]

Thanks Panos, sorry I should have guessed your bugzilla name but I didnt know it hence ni'ing paul

It seems to me that Components.stack.callee applied to the current stack, and not the stack in which the JS ran that triggered the error observer, but that was a guess, I will open a follow up bug to get stacks added to these, try it out and get back to you if I hit any problems

Comment 10

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8454549 [details] [review]
https://github.com/mozilla-b2g/marionette-js-logger/pull/11

LGTM. You may rebase / merge / cherry-pick / whatever you like once travis passes. Thanks dale!

Comment 11

[Dale Harvey (:daleharvey)]

Sweet thanks, merged: https://github.com/mozilla-b2g/marionette-js-logger/commit/bc3121e7ecb243fd1f261e43f5462355ba0b8bfa

Comment 12

[Kevin Grandon :kgrandon]

Included in marionette-js-runner here, and bumped to 0.5.4: https://github.com/mozilla-b2g/marionette-js-runner/commits/master
Landed in gaia-node-modules: https://github.com/mozilla-b2g/gaia-node-modules/commit/78bf8043d77279dee3c6266b46cb117435ae9a54

Working on getting this into gaia now.

Comment 13

[Kevin Grandon :kgrandon]

Dependencies now in master: https://github.com/mozilla-b2g/gaia/commit/e15394725148c2613dcd4e7a25bcceca39bd795f