1033859 - [ringtones][settings] Ringer selector uses < (back) instead of x (cancel)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Ringtones, defect)

Description

[Tiffanie Shakespeare [:tif]]

STR
1. Go to Settings -> Sound
2. Tap on button under Ringer label to change the default sound
3. Observe header

Expected
An X should be on the left side to cancel changes and return without saving

Actual
A < is shown

Comment 1

[Tiffanie Shakespeare [:tif]]

Hema/Sri - this was the other issue I mentioned during 2.1 planning yesterday. I thought there was an existing bug for it but I can't find it.

Comment 2

[Jim Porter (:squib)]

I think that's bug 822740, but this one seems clearer, so maybe we should keep this one and dup the other one?

Comment 3

[Tiffanie Shakespeare [:tif]]

Nicely found! I think you are correct. Let's do that since this bug will fix the other one too.

(In reply to Jim Porter (:squib) from comment #2)
> I think that's bug 822740, but this one seems clearer, so maybe we should
> keep this one and dup the other one?

Comment 5

[Punam Dahiya [:pdahiya]]

Hi Tif

Few clarifications on the scope of this bug

1. Both Ringer and Alerts under settings -> sound , should be updated with the requirement in original description of this bug #comment 0

2. Will need your help to provide the cancel icon (grey) to be used in the header.

Thanks

Comment 6

[Tiffanie Shakespeare [:tif]]

Adding Jenny who is the Settings designer to keep her in the loop. Jenny, please let us know if you foresee an issue with updating the Alert picker to mirror the Ringer picker.

Punam - for comment #2, we're using a building block, does that not provide an X icon? If not, I think Carol (Settings visual designer) or Peko (Ringtone visual designer) may be able to provide the asset. 

Ladies - can you help Punam hunt down the X we'd need for the header in ringer/alert picker in Sound Settings?

Thanks!

Comment 7

[Jenny Lee]

(In reply to Tiffanie Shakespeare from comment #6)

Hey Tif! All header that comes with a "done" or "Ok" on the right should use "X" on the left according to latest building block guidelines. And I think the "X" icon is already covered ;)

Comment 8

[Punam Dahiya [:pdahiya]]

Attachment: PR with fix of Bug 1033859

Attaching PR with updating back icon to cancel in ringer and alert selector header. Please review. Thanks

Comment 9

[Hema Koka [:hema]]

Will be in 2.1

Comment 10

[Carol Huang [:Carol]]

I think the image is covered since it's shared assets.

Comment 11

[Jim Porter (:squib)]

Comment on attachment 8452956 [details] [review]
PR with fix of Bug 1033859

rs=me

Comment 12

[Tiffanie Shakespeare [:tif]]

Comment on attachment 8452956 [details] [review]
PR with fix of Bug 1033859

Looks good - thanks!!

Comment 13

[Punam Dahiya [:pdahiya]]

Thanks for the review. Patch landed on master
https://github.com/mozilla-b2g/gaia/commit/b8576da2c7adc92220c9bb89c90e4a6cca8b098d

Comment 14

[Peko Chen [:pekochen]]

since the bug is closed
clear ni