Closed
Bug 1033919
Opened 10 years ago
Closed 10 years ago
Second touch should be blocked if the alt char menu is shown
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.0 S5 (4july)
People
(Reporter: timdream, Assigned: timdream)
References
Details
(Keywords: regression, Whiteboard: [p=1])
Attachments
(1 file)
+++ This bug was initially created as a clone of Bug #1025520 +++ STR: 1. Hold the I key, wait for the alt char menu 2. Tap the D key 3. Release the D key Expected: 1. The D key is ignored, nothing happens. Actual: 1. D is sent to the text field and the alt char menu is gone 2. ï is sent when the first finger is released from the I key. This is a regression from the cloned bug. The behavior is actual kept because there was a JS error when the D key is relased: E/GeckoConsole( 1205): [JavaScript Error: "TypeError: touchedKeys[touchId] is undefined" {file: "app://keyboard.gaiamobile.org/js/keyboard.js" line: 756}] Not sure if this behavior is spec'd but I think I should keep the old behavior.
Assignee | ||
Updated•10 years ago
|
Whiteboard: [p=5] → [p=3]
Target Milestone: --- → 2.0 S6 (18july)
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8450062 [details] [review] mozilla-b2g:master PR#21334 There isn't a test for this patch but I don't think it's worthy of writing another integration test just to protect this behavior.
Attachment #8450062 -
Flags: review?(rlu)
Assignee | ||
Updated•10 years ago
|
Whiteboard: [p=3] → [p=1]
Target Milestone: 2.0 S6 (18july) → 2.0 S5 (4july)
Comment 3•10 years ago
|
||
Comment on attachment 8450062 [details] [review] mozilla-b2g:master PR#21334 r=me with a comment on GH. Thank you.
Attachment #8450062 -
Flags: review?(rlu) → review+
Assignee | ||
Comment 4•10 years ago
|
||
master: https://github.com/mozilla-b2g/gaia/commit/b97163a46d5a3dfd36ead620173b2e72c434f8a0
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•