1033919 - Second touch should be blocked if the alt char menu is shown

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

+++ This bug was initially created as a clone of Bug #1025520 +++

STR:

1. Hold the I key, wait for the alt char menu
2. Tap the D key
3. Release the D key

Expected:

1. The D key is ignored, nothing happens.

Actual:

1. D is sent to the text field and the alt char menu is gone
2. ï is sent when the first finger is released from the I key.

This is a regression from the cloned bug. The behavior is actual kept because there was a JS error when the D key is relased: 

E/GeckoConsole( 1205): [JavaScript Error: "TypeError: touchedKeys[touchId] is undefined" {file: "app://keyboard.gaiamobile.org/js/keyboard.js" line: 756}]

Not sure if this behavior is spec'd but I think I should keep the old behavior.

Comment 1

[Mozilla Shepherd (This account is used for automation and doesn't receive bugmail)]

Attachment: mozilla-b2g:master PR#21334

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8450062 [details] [review]
mozilla-b2g:master PR#21334

There isn't a test for this patch but I don't think it's worthy of writing another integration test just to protect this behavior.

Comment 3

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8450062 [details] [review]
mozilla-b2g:master PR#21334

r=me with a comment on GH.
Thank you.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

master: https://github.com/mozilla-b2g/gaia/commit/b97163a46d5a3dfd36ead620173b2e72c434f8a0