Closed Bug 1034212 Opened 11 years ago Closed 11 years ago

Enable devtools/webaudioeditor tests for e10s

Categories

(DevTools Graveyard :: Web Audio Editor, defect)

Product:
DevTools Graveyard
Component:
Web Audio Editor
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(e10s+)

Status:
RESOLVED FIXED
Milestone:
Firefox 33
Tracking Flags:
Tracking Status
e10s + ---

People

(Reporter: jsantell, Assigned: jsantell)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

1034212-e10s-wae.patch
800 bytes, patch
vporof
: review+
Details | Diff | Splinter Review
No description provided.
Assignee: nobody → jsantell
Looks like the audio editor is all ready to go for e10s.
Attachment #8450486 - Flags: review?(vporof)
Attachment #8450486 - Flags: review?(vporof) → review+
Shouldn't need a try push, only enabling e10s tests once they're running on tbpl
Status: NEW → ASSIGNED
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/490d0b2957c3
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 33
Reopening -- current changes in e10s cause this to break now.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Blocks: 1040352
Works once bug 1041597 is fixed. Leaving open for a bit though, I think some other things can cause this to change.
This is solid.
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
QA Whiteboard: [qa-]
Maybe something has changed since this landed, since I'm seeing failures for the webaudioeditor tests in e10s on Holly (https://tbpl.mozilla.org/?tree=Holly). For instance: https://tbpl.mozilla.org/php/getParsedLog.php?id=46492079. Looks to be the same errors that I've seen on the profiler and canvasdebugger tests (Bug 1058879 and 1058898). A call to target.window.wrappedJSObject - http://dxr.mozilla.org/mozilla-central/source/browser/devtools/webaudioeditor/test/head.js#134. Victor, any ideas? Failing logs: 19979 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_audionode-actor-get-param-flags.js | Got an error: target.window is null 19984 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_audionode-actor-get-param-flags.js | Found an unexpected tab at the end of test run: http://example.com/browser/browser/devtools/webaudioeditor/test/doc_simple-node-creation.html 20065 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_audionode-actor-get-params-01.js | Got an error: target.window is null 20067 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_audionode-actor-get-params-01.js | Found an unexpected tab at the end of test run: http://example.com/browser/browser/devtools/webaudioeditor/test/doc_simple-node-creation.html 20130 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_audionode-actor-get-params-02.js | Got an error: target.window is null 20136 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_audionode-actor-get-params-02.js | Found an unexpected tab at the end of test run: http://example.com/browser/browser/devtools/webaudioeditor/test/doc_simple-node-creation.html 20202 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_audionode-actor-get-set-param.js | Got an error: target.window is null 20205 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_audionode-actor-get-set-param.js | Found an unexpected tab at the end of test run: http://example.com/browser/browser/devtools/webaudioeditor/test/doc_simple-context.html 20277 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_audionode-actor-get-type.js | Got an error: target.window is null 20279 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_audionode-actor-get-type.js | Found an unexpected tab at the end of test run: http://example.com/browser/browser/devtools/webaudioeditor/test/doc_simple-node-creation.html 20348 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_audionode-actor-is-source.js | Got an error: target.window is null 20362 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_audionode-actor-is-source.js | Found an unexpected tab at the end of test run: http://example.com/browser/browser/devtools/webaudioeditor/test/doc_simple-node-creation.html 20428 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_destroy-node-01.js | Got an error: target.window is null 20430 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_destroy-node-01.js | Found an unexpected tab at the end of test run: http://example.com/browser/browser/devtools/webaudioeditor/test/doc_destroy-nodes.html 20492 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_first-run.js | Got an error: target.window is null 20494 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_first-run.js | Found an unexpected tab at the end of test run: http://example.com/browser/browser/devtools/webaudioeditor/test/doc_simple-context.html 20569 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-click.js | Got an error: target.window is null 20586 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-click.js | Found an unexpected tab at the end of test run: http://example.com/browser/browser/devtools/webaudioeditor/test/doc_complex-context.html 20688 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-markers.js | Got an error: target.window is null 20782 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-markers.js | Found an unexpected tab at the end of test run: http://example.com/browser/browser/devtools/webaudioeditor/test/doc_simple-context.html 20882 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-render-01.js | Got an error: target.window is null 20976 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-render-01.js | Found an unexpected tab at the end of test run: http://example.com/browser/browser/devtools/webaudioeditor/test/doc_simple-context.html 21078 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-render-02.js | Got an error: target.window is null 21096 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-render-02.js | Found an unexpected tab at the end of test run: http://example.com/browser/browser/devtools/webaudioeditor/test/doc_complex-context.html 21431 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-render-03.js | Got an error: target.window is null 21654 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-render-03.js | Found an unexpected tab at the end of test run: http://example.com/browser/browser/devtools/webaudioeditor/test/doc_connect-toggle.html 21754 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-render-04.js | Got an error: target.window is null 21858 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-render-04.js | Found an unexpected tab at the end of test run: http://example.com/browser/browser/devtools/webaudioeditor/test/doc_connect-multi-param.html 21966 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-selected.js | Got an error: target.window is null 22086 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-selected.js | Found an unexpected tab at the end of test run: http://example.com/browser/browser/devtools/webaudioeditor/test/doc_simple-context.html 22192 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-zoom.js | Got an error: target.window is null 22196 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-zoom.js | Found an unexpected tab at the end of test run: http://example.com/browser/browser/devtools/webaudioeditor/test/doc_simple-context.html 22505 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_inspector-toggle.js | Got an error: target.window is null 22701 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_inspector-toggle.js | Found an unexpected tab at the end of test run: http://example.com/browser/browser/devtools/webaudioeditor/test/doc_simple-context.html 22839 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_inspector.js | Got an error: target.window is null 22841 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_inspector.js | Found an unexpected tab at the end of test run: http://example.com/browser/browser/devtools/webaudioeditor/test/doc_simple-context.html 22903 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_properties-view-change-params.js | Got an error: target.window is null 22905 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_properties-view-change-params.js | Found an unexpected tab at the end of test run: http://example.com/browser/browser/devtools/webaudioeditor/test/doc_change-param.html 22967 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_properties-view-media-nodes.js | Got an error: target.window is null 22969 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_properties-view-media-nodes.js | Found an unexpected tab at the end of test run: http://example.com/browser/browser/devtools/webaudioeditor/test/doc_media-node-creation.html 23054 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_properties-view-params-objects.js | Got an error: target.window is null 23065 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_properties-view-params-objects.js | Found an unexpected tab at the end of test run: http://example.com/browser/browser/devtools/webaudioeditor/test/doc_buffer-and-array.html 23128 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_properties-view-params.js | Got an error: target.window is null 23130 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_properties-view-params.js | Found an unexpected tab at the end of test run: http://example.com/browser/browser/devtools/webaudioeditor/test/doc_simple-node-creation.html 23192 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_properties-view.js | Got an error: target.window is null 23194 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_properties-view.js | Found an unexpected tab at the end of test run: http://example.com/browser/browser/devtools/webaudioeditor/test/doc_simple-context.html 23256 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_reset-01.js | Got an error: target.window is null 23258 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_reset-01.js | Found an unexpected tab at the end of test run: http://example.com/browser/browser/devtools/webaudioeditor/test/doc_simple-context.html 23325 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_reset-02.js | Got an error: target.window is null 23344 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_reset-02.js | Found an unexpected tab at the end of test run: http://example.com/browser/browser/devtools/webaudioeditor/test/doc_simple-context.html 23406 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_reset-03.js | Got an error: target.window is null 23408 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_reset-03.js | Found an unexpected tab at the end of test run: http://example.com/browser/browser/devtools/webaudioeditor/test/doc_simple-context.html 23470 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_webaudio-actor-change-params-01.js | Got an error: target.window is null 23472 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_webaudio-actor-change-params-01.js | Found an unexpected tab at the end of test run: http://example.com/browser/browser/devtools/webaudioeditor/test/doc_change-param.html 23534 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_webaudio-actor-change-params-02.js | Got an error: target.window is null 23548 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_webaudio-actor-change-params-02.js | Found an unexpected tab at the end of test run: http://example.com/browser/browser/devtools/webaudioeditor/test/doc_destroy-nodes.html
Flags: needinfo?(vporof)
Blocks: 1058875
Dunno. I think the culprit bug was backed out in the meantime?
Flags: needinfo?(vporof)
This has been merged in, but creating a new bug to track the fixes, bug 1061904
No longer blocks: 1058875
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: