103466 - Mozilla-generated .url files use unix-style EOL (\n) (internet shortcut)

Status: VERIFIED FIXED

(Core :: DOM: Copy & Paste and Drag & Drop, defect)

Description

[Olivier Mengué]

I'm a fan of "Drag 'n drop" of URLs from my browser to directories on my HD. I
discovered this feature on IE, and found that it now works with Mozilla. However
end-of-line is incorrect in Mozilla generated Internet shortcuts.

To reproduce :
- display on your desktop both Mozilla and a Windows Explorer window
- open any web page in Mozilla
- drag the bookmark icon just at the left of the URL in Mozilla, to a directory
in the Explorer window.
- you now have a .URL file that has the same name as the title of the web page.

The problem :
the end-of-line character is \n instead of \r\n as in .url files generated by
Internet Explorer

Only tested on Windows NT.


Note that it isn't probably a Windows only bug : I'm not aware of aplications on
other platforms that create or read .url files other than IE. So Internet
shorcuts files MUST always have \r\n EOL. That way we'll be able to create .url
files from Mozilla on a Linux workstation, and reuse them on a Windows PC.

Comment 1

[Olivier Mengué]

Attachment: Exemple file

Comment 2

[Olivier Mengué]

See also Bug #103468 (another bug related to Mozilla-generated Internet Shortcuts)

Comment 3

[Jesse Ruderman]

-> bookmarks

Comment 4

[Ashley Bischoff (blog at handcoding.com)]

-> XP Apps: Drag and Drop

NEW?

Comment 5

[Daniel Mario Vega (Restore MNG Support --> #18574)]

The problem is here:

http://lxr.mozilla.org/mozilla/source/widget/src/windows/nsDataObj.cpp#528

- static const char* shortcutFormatStr = "[InternetShortcut]\nURL=%s\n";

It should be: 

+ static const char* shortcutFormatStr = "[InternetShortcut]\r\nURL=%s\r\n";
Can someone confirm this bug ?

Comment 6

[Ashley Bischoff (blog at handcoding.com)]

Confirming.

Comment 7

[Blake Ross]

pink should review this.

Comment 8

[Mike Pinkerton (not reading bugmail)]

sure thing, if that's what IE does. test it out first. r=pink.

Comment 9

[Blake Ross]

ok, tested and checked in.

Comment 10

[Daniel Mario Vega (Restore MNG Support --> #18574)]

Blake,

I think the first EOL is still broken. Current situation:

- static const char* shortcutFormatStr = "[InternetShortcut]\nURL=%s\r\n";

It should be this way

+ static const char* shortcutFormatStr = "[InternetShortcut]\r\nURL=%s\r\n";
                                                            ^^
Please reopen

Comment 11

[Daniel Mario Vega (Restore MNG Support --> #18574)]

This bug is fixed on Build ID: 2001101603 (Status:VERIFIED?)

Comment 12

[Olivier Mengué]

Verified as fixed in 0.9.6 (build 2001112009).
But the fix as an impact on bug #103468. Please fix this bug too.