1034664 - The canvas graphs should use a cache of canvas elements instead of creating a new one every time an off-screen render target is needed

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Description

[Victor Porof [:vporof][:vp]]

Title should be self-explanatory. We're creating new canvases quite a lot for offscreen rendering. This can be optimized.

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 2

[Patrick Brosset <:pbro>]

Comment on attachment 8451095 [details] [diff] [review]
v1

Review of attachment 8451095 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/shared/widgets/Graphs.jsm
@@ +578,5 @@
>      this.emit("refresh");
>    },
>  
>    /**
> +   * Gets a canvas with the specified name, for this specific graph.

nit: That's a lot of "specific"! I think just "Gets a canvas with the specified name, for this graph." would be enough.

Comment 3

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/2572054ce72f

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2572054ce72f