1034670 - The canvas graphs should draw the background separately from the plotted data

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Description

[Victor Porof [:vporof][:vp]]

Needed for bug 1034669.

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 2

[Patrick Brosset <:pbro>]

Comment on attachment 8451104 [details] [diff] [review]
v1

Review of attachment 8451104 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/shared/widgets/Graphs.jsm
@@ +645,4 @@
>      let ctx = this._ctx;
>      ctx.clearRect(0, 0, this._width, this._height);
>  
> +    if (this._cachedHighlightMask) {

I think you meant this._cachedBackgroundImage here instead.

@@ +645,5 @@
>      let ctx = this._ctx;
>      ctx.clearRect(0, 0, this._width, this._height);
>  
> +    if (this._cachedHighlightMask) {
> +      ctx.drawImage(this._cachedHighlightMask, 0, 0, this._width, this._height);

And here.

Comment 3

[Victor Porof [:vporof][:vp]]

Attachment: v2

Yup!

Comment 4

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/de13eef240d6

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/de13eef240d6