Closed Bug 1034956 Opened 10 years ago Closed 10 years ago

[Flatfish][TCP] Remove "Silence incoming calls" option from tablet interface.

Categories

(Firefox OS Graveyard :: Gaia, defect)

Product:
Firefox OS Graveyard
Component:
Gaia
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: caspy77, Assigned: chens)

References

Details

(Whiteboard: [Flatfish][TCP])

Attachments

(1 file, 1 obsolete file)

Pull request
46 bytes, text/x-github-pull-request
alive
: review+
Details | Review 
Hold down the power button and you will be presented with a few options.
Notably among these options is "Silence incoming calls"
As a tablet this is not an appropriate option.  

I don't have a phone, but I'm curious, does this option also mute other notifications (such as reminders and other apps)?  If so, perhaps rather than removing it outright, we ought to consider replacing it with something like "Mute notifications".

Also, at the top of this option panel is text that says "Phone" which also needs changed.
Summary: [Flatfish] Remove "Silence incoming calls" option from tablet interface. → [Flatfish][TCP] Remove "Silence incoming calls" option from tablet interface.
Whiteboard: [Flatfish] → [Flatfish][TCP]
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee: nobody → shchen
Attached file Pull request (obsolete) — 

        Attachment #8459405 -
        Flags: review?(alive)

    
    

    
  

      
      
      
      

        Attached file
          
        Pull request
        — 
      

    


  
also fix gaia-ui-test

        Attachment #8459405 -
        Attachment is obsolete: true

        Attachment #8459405 -
        Flags: review?(alive)

        Attachment #8459415 -
        Flags: review?(alive)

    
    

    
  
Comment on attachment 8459415 [details] [review]
Pull request

If there's a strong reason not using navigator.mozTelephony then please user share mocks for mozMobileConnections..

        Attachment #8459415 -
        Flags: review?(alive) → review+

    
    

    
  
Comment on attachment 8459415 [details] [review]
Pull request

Update pull request, use mozTelephony instead of mozMobileConnections.

        Attachment #8459415 -
        Flags: feedback?(alive)

    
    

    
  
Merged to master
https://github.com/mozilla-b2g/gaia/commit/3350409b239917eee74bc6732da62f1fe383c798
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

    
    

    
  
Comment on attachment 8459415 [details] [review]
Pull request

Not feedback since merged.

        Attachment #8459415 -
        Flags: feedback?(alive)

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: