Closed Bug 1035131 Opened 11 years ago Closed 11 years ago

Fix issues around user entered pinned sites and suggested sites

Categories

(Firefox for Android Graveyard :: Awesomescreen, defect)

Product:
Firefox for Android Graveyard
Component:
Awesomescreen
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox32 fixed, firefox33 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 33
Tracking Flags:
Tracking Status
firefox32 --- fixed
firefox33 --- fixed

People

(Reporter: lucasr, Assigned: lucasr)

References

Details

Attachments

(3 files)

Factor out methods to encode/decode user-entered:// URLs (r=mfinkle)
9.34 KB, patch
mfinkle
: review+
lmandel
: approval-mozilla-aurora+
Details | Diff | Splinter Review
User decoded user entered URLs in suggeste image lookups (r=mfinkle)
1.80 KB, patch
mfinkle
: review+
lmandel
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Decode user entered URLs to exclude from suggested sites (r=mfinkle)
3.69 KB, patch
mfinkle
: review+
lmandel
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Including: - Suggested images should use decoded url for image lookups - Suggested sites filtering should use decoded urls from pinned sites
Comment on attachment 8451604 [details] [diff] [review] Factor out methods to encode/decode user-entered:// URLs (r=mfinkle) So that these methods can be naturally reused in other parts of the code.
Attachment #8451604 - Flags: review?(mark.finkle)
Comment on attachment 8451605 [details] [diff] [review] User decoded user entered URLs in suggeste image lookups (r=mfinkle) Avoid doing suggested image lookups with URLs like user-entered:http://example.com. We should use the decoded version instead i.e. http://example.com.
Attachment #8451605 - Flags: review?(mark.finkle)
Comment on attachment 8451606 [details] [diff] [review] Decode user entered URLs to exclude from suggested sites (r=mfinkle) Use the decoded version of any user-entered URLs to be excluded from the list of suggested sites.
Attachment #8451606 - Flags: review?(mark.finkle)
Attachment #8451604 - Flags: review?(mark.finkle) → review+
Attachment #8451605 - Flags: review?(mark.finkle) → review+
Attachment #8451606 - Flags: review?(mark.finkle) → review+
Comment on attachment 8451604 [details] [diff] [review] Factor out methods to encode/decode user-entered:// URLs (r=mfinkle) Approval Request Comment [Feature/regressing bug #]: bug 988366 [User impact if declined]: Top sites grid can get into unexpected states due to incorrect interaction between suggested and pinned sites. [Describe test coverage new/current, TBPL]: Local test. Let's bake this in Nightly for a couple days and then uplift. [Risks and why]: Low, we're simply making sure we use the decoded URLs on suggested site operations. [String/UUID change made/needed]: n/a
Attachment #8451604 - Flags: approval-mozilla-aurora?
Comment on attachment 8451605 [details] [diff] [review] User decoded user entered URLs in suggeste image lookups (r=mfinkle) Approval Request Comment [Feature/regressing bug #]: bug 988366 [User impact if declined]: Top sites grid can get into unexpected states due to incorrect interaction between suggested and pinned sites. [Describe test coverage new/current, TBPL]: Local test. Let's bake this in Nightly for a couple days and then uplift. [Risks and why]: Low, we're simply making sure we use the decoded URLs on suggested site operations. [String/UUID change made/needed]: n/a
Attachment #8451605 - Flags: approval-mozilla-aurora?
Comment on attachment 8451606 [details] [diff] [review] Decode user entered URLs to exclude from suggested sites (r=mfinkle) Approval Request Comment [Feature/regressing bug #]: bug 988366 [User impact if declined]: Top sites grid can get into unexpected states due to incorrect interaction between suggested and pinned sites. [Describe test coverage new/current, TBPL]: Local test. Let's bake this in Nightly for a couple days and then uplift. [Risks and why]: Low, we're simply making sure we use the decoded URLs on suggested site operations. [String/UUID change made/needed]: n/a
Attachment #8451606 - Flags: approval-mozilla-aurora?
Comment on attachment 8451605 [details] [diff] [review] User decoded user entered URLs in suggeste image lookups (r=mfinkle) Aurora+ Bug 988366 is a metabug. Do you know in what release this issue was introduced?
Attachment #8451605 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #8451606 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(In reply to Lawrence Mandel [:lmandel] from comment #12) > Comment on attachment 8451605 [details] [diff] [review] > User decoded user entered URLs in suggeste image lookups (r=mfinkle) > > Aurora+ > > Bug 988366 is a metabug. Do you know in what release this issue was > introduced? Likely bug 997782.
Comment on attachment 8451604 [details] [diff] [review] Factor out methods to encode/decode user-entered:// URLs (r=mfinkle) Looks like I missed +ing one of bugs earlier. Cleaning up.
Attachment #8451604 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: