1035131 - Fix issues around user entered pinned sites and suggested sites

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Lucas Rocha (:lucasr)]

Including:
- Suggested images should use decoded url for image lookups
- Suggested sites filtering should use decoded urls from pinned sites

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Factor out methods to encode/decode user-entered:// URLs (r=mfinkle)

Comment 2

[Lucas Rocha (:lucasr)]

Attachment: User decoded user entered URLs in suggeste image lookups (r=mfinkle)

Comment 3

[Lucas Rocha (:lucasr)]

Attachment: Decode user entered URLs to exclude from suggested sites (r=mfinkle)

Comment 4

[Lucas Rocha (:lucasr)]

Comment on attachment 8451604 [details] [diff] [review]
Factor out methods to encode/decode user-entered:// URLs (r=mfinkle)

So that these methods can be naturally reused in other parts of the code.

Comment 5

[Lucas Rocha (:lucasr)]

Comment on attachment 8451605 [details] [diff] [review]
User decoded user entered URLs in suggeste image lookups (r=mfinkle)

Avoid doing suggested image lookups with URLs like user-entered:http://example.com. We should use the decoded version instead i.e. http://example.com.

Comment 6

[Lucas Rocha (:lucasr)]

Comment on attachment 8451606 [details] [diff] [review]
Decode user entered URLs to exclude from suggested sites (r=mfinkle)

Use the decoded version of any user-entered URLs to be excluded from the list of suggested sites.

Comment 7

[Lucas Rocha (:lucasr)]

https://hg.mozilla.org/integration/fx-team/rev/b459090bc1e3
https://hg.mozilla.org/integration/fx-team/rev/f26a0f525fb4
https://hg.mozilla.org/integration/fx-team/rev/f14b47c39013

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b459090bc1e3
https://hg.mozilla.org/mozilla-central/rev/f26a0f525fb4
https://hg.mozilla.org/mozilla-central/rev/f14b47c39013

Comment 9

[Lucas Rocha (:lucasr)]

Comment on attachment 8451604 [details] [diff] [review]
Factor out methods to encode/decode user-entered:// URLs (r=mfinkle)

Approval Request Comment
[Feature/regressing bug #]: bug 988366
[User impact if declined]: Top sites grid can get into unexpected states due to incorrect interaction between suggested and pinned sites.
[Describe test coverage new/current, TBPL]: Local test. Let's bake this in Nightly for a couple days and then uplift.
[Risks and why]: Low, we're simply making sure we use the decoded URLs on suggested site operations.
[String/UUID change made/needed]: n/a

Comment 10

[Lucas Rocha (:lucasr)]

Comment on attachment 8451605 [details] [diff] [review]
User decoded user entered URLs in suggeste image lookups (r=mfinkle)

Approval Request Comment
[Feature/regressing bug #]: bug 988366
[User impact if declined]: Top sites grid can get into unexpected states due to incorrect interaction between suggested and pinned sites.
[Describe test coverage new/current, TBPL]: Local test. Let's bake this in Nightly for a couple days and then uplift.
[Risks and why]: Low, we're simply making sure we use the decoded URLs on suggested site operations.
[String/UUID change made/needed]: n/a

Comment 11

[Lucas Rocha (:lucasr)]

Comment on attachment 8451606 [details] [diff] [review]
Decode user entered URLs to exclude from suggested sites (r=mfinkle)

Approval Request Comment
[Feature/regressing bug #]: bug 988366
[User impact if declined]: Top sites grid can get into unexpected states due to incorrect interaction between suggested and pinned sites.
[Describe test coverage new/current, TBPL]: Local test. Let's bake this in Nightly for a couple days and then uplift.
[Risks and why]: Low, we're simply making sure we use the decoded URLs on suggested site operations.
[String/UUID change made/needed]: n/a

Comment 12

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8451605 [details] [diff] [review]
User decoded user entered URLs in suggeste image lookups (r=mfinkle)

Aurora+

Bug 988366 is a metabug. Do you know in what release this issue was introduced?

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2ffb6fe34484
https://hg.mozilla.org/releases/mozilla-aurora/rev/5ece78da865b
https://hg.mozilla.org/releases/mozilla-aurora/rev/867e77cc2342

Comment 14

[Lucas Rocha (:lucasr)]

(In reply to Lawrence Mandel [:lmandel] from comment #12)
> Comment on attachment 8451605 [details] [diff] [review]
> User decoded user entered URLs in suggeste image lookups (r=mfinkle)
> 
> Aurora+
> 
> Bug 988366 is a metabug. Do you know in what release this issue was
> introduced?

Likely bug 997782.

Comment 15

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8451604 [details] [diff] [review]
Factor out methods to encode/decode user-entered:// URLs (r=mfinkle)

Looks like I missed +ing one of bugs earlier. Cleaning up.