Closed Bug 1035211 Opened 6 years ago Closed 6 years ago
Changing between "Never remember history" and other settings in about:preferences#privacy and clicking "OK" in the resulting dialog is broken
Instead the browser console shows: TypeError: document.documentElement.acceptDialog is not a function privacy.js:284
AFAICT this can just go away. Was added in bug 842290, but in-content prefs always instant-apply, and there's no dialog to acceptDialog, so this line should just go DIAF. :-)
Attachment #8451740 - Flags: review?(jaws)
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Care to investigate the other acceptDialog calls in the tests (follow-up bug is fine)? http://mxr.mozilla.org/mozilla-central/search?find=%2Fbrowser%2Fcomponents%2Fpreferences%2Fin-content%2F&string=acceptDialog
Attachment #8451740 - Flags: review?(jaws) → review+
remote: https://hg.mozilla.org/integration/fx-team/rev/891be3548d43 Marco, can you add this for the upcoming iteration? It'll need manual verification because we don't have tests for bits that require restarts...
Iteration: --- → 33.3
Points: 2 → 1
QA Whiteboard: [qa+]
Added to the priority list for Iteration 33.3
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
Hi Florin, can a QA contact be assigned for verification of this bug.
QA Contact: camelia.badau
Verified fixed on Mac OSX 10.8.5 using latest Nightly (buildID: 20140709030201).
Status: RESOLVED → VERIFIED
QA Whiteboard: [qa+] → [qa!]
You need to log in before you can comment on or make changes to this bug.