Changing between "Never remember history" and other settings in about:preferences#privacy and clicking "OK" in the resulting dialog is broken

VERIFIED FIXED in Firefox 33

Status

()

Firefox
Preferences
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: Gijs, Assigned: Gijs)

Tracking

Trunk
Firefox 33
x86_64
Mac OS X
Points:
1
Dependency tree / graph
Bug Flags:
firefox-backlog +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Instead the browser console shows:

TypeError: document.documentElement.acceptDialog is not a function

privacy.js:284
Flags: firefox-backlog+
(Assignee)

Comment 1

4 years ago
Created attachment 8451740 [details] [diff] [review]
don't call acceptDialog for in-content prefs,

AFAICT this can just go away. Was added in bug 842290, but in-content prefs always instant-apply, and there's no dialog to acceptDialog, so this line should just go DIAF. :-)
Attachment #8451740 - Flags: review?(jaws)
(Assignee)

Updated

4 years ago
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Attachment #8451740 - Flags: review?(jaws) → review+
(Assignee)

Updated

4 years ago
Depends on: 1035308
(Assignee)

Comment 3

4 years ago
remote:   https://hg.mozilla.org/integration/fx-team/rev/891be3548d43

Marco, can you add this for the upcoming iteration? It'll need manual verification because we don't have tests for bits that require restarts...
Iteration: --- → 33.3
Points: 2 → 1
QA Whiteboard: [qa+]
Flags: needinfo?(mmucci)
Whiteboard: [fixed-in-fx-team]
Added to the priority list for Iteration 33.3
Flags: needinfo?(mmucci)
https://hg.mozilla.org/mozilla-central/rev/891be3548d43
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 33
Hi Florin, can a QA contact be assigned for verification of this bug.
Flags: needinfo?(florin.mezei)
Flags: needinfo?(florin.mezei)
QA Contact: camelia.badau
Verified fixed on Mac OSX 10.8.5 using latest Nightly (buildID: 20140709030201).
Status: RESOLVED → VERIFIED
QA Whiteboard: [qa+] → [qa!]
You need to log in before you can comment on or make changes to this bug.