842290 - "Restart Aurora" pop up doesn't appear when selecting private browsing mode

Status: VERIFIED FIXED

(Firefox :: Private Browsing, defect)

Description

[Ada [:adalucinet]]

Reproducible on the latest Aurora (Build ID: 20130217042019): Mozilla/5.0 (Windows NT 6.2; rv:20.0) Gecko/20130217 Firefox/20.0 
Reproducible on the latest Nightly (BuildID: 20130217031005): Mozilla/5.0 (Windows NT 6.2; rv:21.0) Gecko/20130217 Firefox/21.0

Steps to reproduce:
1. Launch Firefox.
2. Go to Options -> Privacy and select "Use custom settings for history" for "Aurora will:".
3. Check the "Always use private browsing mode" checkbox.

Expected results: "Restart Aurora" pop up appears.

Actual results: No pop up appears.

Note: 
1. If I hit Ok or Cancel button with/without selecting the checkbox, at a second attempt, the pop up appears when clicking the checkbox.
2. I consider this issue related with the push from bug 801823.

Comment 1

[(no longer active)]

Hmm, this is very surprising.  I thought that bug 826371 has fixed this issue for both the checkbox and the drop-down menu.  When I set the instantApply pref to false on Mac, I cannot reproduce this.  Will test on Windows tomorrow.

Comment 2

[(no longer active)]

This works fine on Widows too.  I suspect you might be trying an old build...

Comment 3

[Michael Kraft [:morac]]

I tested this today in the nightly load and reproduced the problem under Windows XP.

Steps to reproduce:
1. Make sure always remember is selected.
2. Change it to use custom settings and then check the "Always use private browing mode" checkbox when it appears.
3. Then simply press okay. 

The popup never appears.  

 If the "Always use private browing mode" checkbox is already visible, then checking the box puts up the prompt, but if it's not visible when going to the Privacy Tab, then the prompt won't appear after changing to custom.

Comment 4

[Ada [:adalucinet]]

Here is a screen cast with this issue reproduced on latest Aurora (Build ID: 20130219042021):
http://www.screencast.com/users/AlexandraLucinet/folders/Default/media/94dfdeb7-edb0-4e0e-9fb5-b6b5668b3448

The behavior is the same on latest Nightly (Build ID: 20130219031055).

Comment 5

[(no longer active)]

Could you please do me a favor?  Open about:config in a tab, and in the filter textbox, type "browser.privatebrowsing.autostart", and with that tab and pref visible, open the Options window and perform the steps in comment 3.  When you click on the checkbox and the prompt does not appear, do you see the value of the browser.privatebrowsing.autostart pref changing?  (i.e., is it converted to bold and back to regular text?)

Thanks a lot!

Comment 6

[Michael Kraft [:morac]]

The value does not change until "okay" is pressed.  

I've found that a step is missing in my steps to reproduce.  When opening options, if the pane is already on the "Privacy" pane it will work correctly.  The problem occurs if the pane isn't already displaying the "Privacy" pane when the options open.  It looks like the instantApply property is only read in when options is opened to the "Privacy" pane.

I don't think setting "instantApply" to true is the proper fix to begin with as it's more of a hack work around since "instantApply" is never set for Windows.  A more proper fix would be to check if instantApply is enabled and if it's not, then add an onchange event handler to the checkbox to change the preference and put up the prompt.


Anyway the new steps to reproduce are:

Steps to reproduce:
1. Launch Firefox.
2. Open Options.  If not on "Privacy" pane skip to step #4.
3. Switch to "General" pane, click "Okay" and re-open Options.
4. Switch to "Privacy" pane and select "Use custom settings for history" (if not already selected).
5. Check/Uncheck the "Always use private browsing mode" checkbox.
6. Press "Okay" and then click cancel when prompted.

Expected Results:
After step #5, a prompt should appear.

Actual Results:
Prompt doesn't appear until step #6 and cancelling still results in "browser.privatebrowsing.autostart" changing.

Comment 7

[(no longer active)]

Right.... actually it seems like the fact that instantApply worked like that was a pure accident.  I guess we just need to extend the code to handle the pref change to handle explicit changes in the value of the checkbox and the menulist as well.

Josh, can you please take this?  Thanks!

Comment 8

[Josh Matthews [:jdm]]

This is only a problem on Windows, right? We apply preferences instantly on all other platforms, if I understand correctly.

Comment 9

[(no longer active)]

(In reply to comment #8)
> This is only a problem on Windows, right? We apply preferences instantly on all
> other platforms, if I understand correctly.

That's correct.

Comment 10

[Josh Matthews [:jdm]]

Attachment: Checkpoint

Comment 11

[Josh Matthews [:jdm]]

Attachment: Make privacy preference tab always check for permanent private browsing status changing, regardless of whether pref changes apply instantly.

Comment 12

[Josh Matthews [:jdm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/63c78d8a4486

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/63c78d8a4486

Comment 14

[Josh Matthews [:jdm]]

Comment on attachment 721871 [details] [diff] [review]
Make privacy preference tab always check for permanent private browsing status changing, regardless of whether pref changes apply instantly.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 801823
User impact if declined: Inconsistent behaviour for Windows users when toggling permanent private browsing mode - sometimes they'll get a prompt to restart, other times it won't.
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): Fairly low. The scope for regression is quite focused, and the changes have been tested thoroughly.
String or UUID changes made by this patch: None

Comment 15

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 721871 [details] [diff] [review]
Make privacy preference tab always check for permanent private browsing status changing, regardless of whether pref changes apply instantly.

Please land today for tomorrow's Beta.

Comment 16

[Josh Matthews [:jdm]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6ba714700f7c
https://hg.mozilla.org/releases/mozilla-beta/rev/66f7a90181fb

Comment 17

[Ioana (away)]

Verified as fixed on:
Mozilla/5.0 (Windows NT 6.1; rv:20.0) Gecko/20100101 Firefox/20.0 (20130313170052)

Comment 18

[Ada [:adalucinet]]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20100101 Firefox/21.0

Verified as fixed on Firefox 21 beta 2 (Build ID: 20130408165307)

Comment 19

[Mitza]

Mozilla/5.0 (Windows NT 6.1; rv:22.0) Gecko/20130415 Firefox/22.0

Verified as fixed on Firefox 22(Build ID:20130415004014).

Comment 20

[Mitza]

Mozilla/5.0 (Windows NT 6.1; rv:23.0) Gecko/20130418 Firefox/23.0

Verified as fixed on Firefox latest nightly (Build ID:20130418031048).

Comment 21

[Maria Grazia Alastra [:mga]]

Changing tracking flags and status according to the previous two comments by Mitza.