1035241 - Updating XULRunner to version 33 breaks 3 email integration tests.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Anthony Ricaud (:rik)]

We'd like to update XULrunner to fix bug 1034565. But unfortunately, 3 email tests break with that update.

https://tbpl.mozilla.org/?rev=eaf308d73533331f6d9935215fe28944d157500a&tree=Gaia-Try&jobname=b2g_ubuntu64_vm%20gaia-try%20opt%20test%20gaia-integration

Could someone look into the reason? (Could be a real bug, could be a gecko bug in the particular build I picked)

Comment 1

[Anthony Ricaud (:rik)]

James: Could you find someone to look at this? Thanks!

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

I'll take a look.  Note that James is on PTO for 2 weeks or so and so probably anything you'd needinfo him for you'd want to needinfo me instead.

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

The mail-fakeservers npm package needs to be updated to get the benefits of bug 1006867.  We did that in version 0.0.18, but we might as well upgrade to the current 0.0.19.

I'm assuming https://github.com/mozilla-b2g/gaia-node-modules/blob/master/README.md is an accurate document of how to update stuff and will follow it.  Gaia's README.md doesn't provide anything more useful.  I'll ask in #gaia briefly too though.

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

It appears the docs there are likely superseded by :hub's message to dev-gaia of 4/1/2014 "gaia-node-modules changes".  I'll update the gaia-node-modules README.md and such as part of my series of pull requests.

Comment 5

[Andrew Sutherland [:asuth] (he/him)]

Attachment: Upgrade mail-fakeservers to 0.0.19 and add a comment.

Not quite sure who to direct the review at; :gerard-majax suggested :gaye on IRC.  It's not clear to me whether this type of review should be based on the problem domain (email) or just making sure we don't screw up gaia-node-modules.  :kgrandon has been doing a lot of module stuff to so adding him too.  Mainly in the theory that if I bother enough people, someone will tell me how to update the docs to avoid bothering less people in the future. :)

Comment 6

[Kevin Grandon :kgrandon]

Comment on attachment 8451761 [details] [review]
Upgrade mail-fakeservers to 0.0.19 and add a comment.

Basically as long as the changes to mail-fakeservers have been reviewed, since it is one of our packages, I think you are free to land to gaia-node-modules review-free assuming you still point to a bug for tracking.

I'll go ahead and leave my R+ for the README.md changes, and feel free to land. I assume that the mail-fakeserver changes have been reviewed already?

Comment 7

[Andrew Sutherland [:asuth] (he/him)]

Yes, the 0.0.19 release changes were r=squib.

landed on gaia-node-modules/master:
https://github.com/mozilla-b2g/gaia-node-modules/pull/51
https://github.com/mozilla-b2g/gaia-node-modules/commit/4e1567fc0205ef14dec82cb024c583531eafe829

gaia/master pull request up to watch the try request for paranoia at:
https://github.com/mozilla-b2g/gaia/pull/21458

Comment 8

[Andrew Sutherland [:asuth] (he/him)]

So it took a lot of resetting but I got clean travis run and the 2 gaia-try runs never had anything to do with email, but one vertical homescreen failure did seem to persist.

landed on gaia/master:
https://github.com/mozilla-b2g/gaia/pull/21458
https://github.com/mozilla-b2g/gaia/commit/740faa5d0060fb218b407cf224330654ddf833a5