1034565 - CSSLint complains about CSS Variables

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Wilson Page [:wilsonpage]]

I can't currently commit CSS with CSS variables (custom properties) in.

Comment 1

[Anthony Ricaud (:rik)]

Can you paste the exact error message it gives you?

Comment 2

[Wilson Page [:wilsonpage]]

Expected identifier for variable name but found '-'.  Error in parsing value for 'background'.  Declaration dropped. line: 14 column: 18 source: "  background: var(--header-background, #fff);"

Comment 3

[Anthony Ricaud (:rik)]

This is just because we're using a version of xulrunner that doesn't have CSS variables enabled.

Comment 4

[Anthony Ricaud (:rik)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/21397

Let's see if updating xulrunner breaks some automation.

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8450982 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/21397

r+ with the commit message fixed to include correctly the 3 mandatory files.
Bug XXXXX - Bug title. r=?

Comment 6

[Anthony Ricaud (:rik)]

I'm seeing 3 email integration tests failing with this update. https://tbpl.mozilla.org/?rev=eaf308d73533331f6d9935215fe28944d157500a&tree=Gaia-Try&jobname=b2g_ubuntu64_vm%20gaia-try%20opt%20test%20gaia-integration

I've rebased my pull request in case that was an error on master when I created my pull request.

Comment 7

[Anthony Ricaud (:rik)]

So those are real reds. I've opened bug 1035241 to ask the email to look into them.

Comment 8

[Andrew Sutherland [:asuth] (he/him)]

I landed the fix on bug 1035241 and it looks like it stuck, so I think you're clear to rebase and then probably land?

Comment 9

[Anthony Ricaud (:rik)]

Wow, thanks for this quick fix!

Another try run is at https://tbpl.mozilla.org/?rev=cbb119a94b01908aedc132531f5a2771a75695f9&tree=Gaia-Try

Comment 10

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

I got segfault on xulrunner-30a1 on bug 1029385 and I think this pr may fix this issue.

Comment 11

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

shoud we also need to upgrade to xulrunner 33 on gaia try server?

Comment 12

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Rik, will you land it soon? I need to upgrade xulrunner from 30a1 to 30 for bug 1029967 and bug 1029385, but I just test your patch and it also can solve my issues.

I'm thinking to file another bug or wait your patch.

Comment 13

[Anthony Ricaud (:rik)]

I'm just waiting for a green TBPL/Travis. So please wait :)

Comment 14

[Anthony Ricaud (:rik)]

(In reply to Yuren [:yurenju] from comment #11)
> shoud we also need to upgrade to xulrunner 33 on gaia try server?
I'm actually having issues with Try. I'm not familiar with the Try environment so I don't know what we're supposed to do here. https://tbpl.mozilla.org/php/getParsedLog.php?id=43735179&tree=Gaia-Try

Comment 15

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

jhford, do you know how to run gaia_integration.py locally? I used the command copy from tbpl but it does not work.

python scripts/gaia_integration.py --cfg config/b2g/gaia_integration_config.py -c config/b2g/gaia_try.py -c http://hg.mozilla.org/integration/gaia-try/raw-file/95f6a122b314673b0f3d87d17dda1939b8756bcc/linux64.json --download-symbols ondemand

Comment 16

[John Ford [:jhford] CET/CEST Berlin Time]

did you clone mozharness?  You'll need to clone mozharness locally.  That command will be run in the root of that repository.  You'll also need to create a buildprops.json file which looks like one from a sample run.

Comment 17

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

I can reproduce it locally, thanks jhford.

Comment 18

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

I don't know why, but  we missed a comma in tbpl-manifest.json on rik's branch, rebase can solve this issue \o/

https://github.com/mozilla-b2g/gaia/blob/master/shared/test/integration/tbpl-manifest.json#L26

Comment 19

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

filed bug 1039967 for jsonlint.

Comment 20

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

wrong link on comment 18, this is right one:
https://github.com/Rik/gaia/blob/9da71075ddde0c842d224449bef9f42a2d8786ee/shared/test/integration/tbpl-manifest.json#L26

Comment 21

[Anthony Ricaud (:rik)]

Green try \o/ https://tbpl.mozilla.org/?rev=a06ee953a189bb79d2cb975f1ffe63278a19680c&tree=Gaia-Try

Comment 22

[Anthony Ricaud (:rik)]

https://github.com/mozilla-b2g/gaia/commit/51ce45b25eaf9cdba330aa11b77eb9dae475e98a

Thanks Yuren and John for the help!

Comment 23

[Ryan VanderMeulen [:RyanVM]]

Reverted for Windows B2G bustage.
Master: https://github.com/mozilla-b2g/gaia/commit/08ea668489ac106a8fa8d24e9353bd1d748cd7c3

https://tbpl.mozilla.org/php/getParsedLog.php?id=44055016&full=1&branch=b2g-inbound

Downloading XULRunner...
wget -q -c https://ftp.mozilla.org/pub/mozilla.org/xulrunner/nightly/2014/07/2014-07-04-03-02-08-mozilla-central/xulrunner-33.0a1.en-US.win32.sdk.zip
Makefile:619: recipe for target 'xulrunner-sdk-33' failed
mozmake.exe[6]: Leaving directory 'c:/builds/moz2_slave/b2g-in-w32_g-00000000000000000/build/gaia'
Makefile:22: recipe for target 'libs' failed
mozmake.exe[5]: Leaving directory 'c:/builds/moz2_slave/b2g-in-w32_g-00000000000000000/build/obj-firefox/b2g/gaia'
c:/builds/moz2_slave/b2g-in-w32_g-00000000000000000/build/config/recurse.mk:94: recipe for target 'b2g/gaia/libs' failed
mozmake.exe[4]: Leaving directory 'c:/builds/moz2_slave/b2g-in-w32_g-00000000000000000/build/obj-firefox'
c:/builds/moz2_slave/b2g-in-w32_g-00000000000000000/build/config/recurse.mk:38: recipe for target 'libs' failed
mozmake.exe[3]: Leaving directory 'c:/builds/moz2_slave/b2g-in-w32_g-00000000000000000/build/obj-firefox'
c:/builds/moz2_slave/b2g-in-w32_g-00000000000000000/build/config/rules.mk:584: recipe for target 'default' failed
mozmake.exe[2]: Leaving directory 'c:/builds/moz2_slave/b2g-in-w32_g-00000000000000000/build/obj-firefox'
c:/builds/moz2_slave/b2g-in-w32_g-00000000000000000/build/client.mk:386: recipe for target 'realbuild' failed
mozmake.exe[1]: Leaving directory 'c:/builds/moz2_slave/b2g-in-w32_g-00000000000000000/build'
client.mk:168: recipe for target 'build' failed
mozmake.exe[6]: *** [xulrunner-sdk-33] Error 1

Comment 24

[Nick Thomas [:nthomas] (UTC+12)]

wget -q completely obscures the error here, but the problem is

$ wget -c https://ftp.mozilla.org/pub/mozilla.org/xulrunner/nightly/2014/07/2014-07-04-03-02-08-mozilla-central/xulrunner-33.0a1.en-US.win32.sdk.zip
--18:51:52--  https://ftp.mozilla.org/pub/mozilla.org/xulrunner/nightly/2014/07/2014-07-04-03-02-08-mozilla-central/xulrunner-33.0a1.en-US.win32.sdk.z
ip
           => `xulrunner-33.0a1.en-US.win32.sdk.zip'
Resolving ftp.mozilla.org... 63.245.215.56, 63.245.215.46
Connecting to ftp.mozilla.org|63.245.215.56|:443... connected.
ERROR: Certificate verification error for ftp.mozilla.org: certificate signature failure
To connect to ftp.mozilla.org insecurely, use `--no-check-certificate'.
Unable to establish SSL connection.

So stick with http in the short term. 

If this change sticks, we'll need a followup like bug 1025731 to use the new xulrunner in gaia tests.

Comment 25

[Anthony Ricaud (:rik)]

Thanks for the investigation Nick.

I relanded with http:// in https://github.com/mozilla-b2g/gaia/commit/46936847de6aced8cfe3d5bf8844134461bd97c3.

I'll open the followup if it sticks.