Closed
Bug 1036014
Opened 11 years ago
Closed 11 years ago
Try alias for Android 2.3 xpcshell tests
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gbrown, Assigned: Callek)
Details
Attachments
(1 file)
814 bytes,
patch
|
RyanVM
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #969991 +++
Try pushes with -u xpcshell do not trigger Android 2.3's xpcshell-1, xpcshell-2, and xpcshell-3, sometimes resulting in confusion and disappointment. RyanVM suggested an alias and pointed me at https://hg.mozilla.org/build/buildbotcustom/rev/e9a52c460141.
See https://tbpl.mozilla.org/?tree=Try&rev=88d5ab0797e3&showall=1 for an example.
I wonder if there are other Android cases that could be improved?
-u robocop?
Assignee | ||
Comment 1•11 years ago
|
||
this was a quick patch while I saw the IRC discussion. Helps make devs lives easier.
Assignee: nobody → bugspam.Callek
Status: NEW → ASSIGNED
Attachment #8452575 -
Flags: review?(ryanvm)
Comment 2•11 years ago
|
||
Comment on attachment 8452575 [details] [diff] [review]
[buildbotcustom] v1
Review of attachment 8452575 [details] [diff] [review]:
-----------------------------------------------------------------
::: try_parser.py
@@ +19,4 @@
> return v.startswith('jittest')
> elif u in ('mochitest-o', 'mochitest-chrome', 'mochitest-a11y'):
> return re.search('mochitest-o', v)
> + elif u in ('xpcshells', 'xpcshell'):
Trychooser has an explicit "jittests" option on it. It doesn't have an "xpcshells" option that I'm aware of, so I don't think we need to support this.
Attachment #8452575 -
Flags: review?(ryanvm) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Pushed with nit addressed: https://hg.mozilla.org/build/buildbotcustom/rev/c695faf1f43d
Comment 4•11 years ago
|
||
In production.
![]() |
Reporter | |
Comment 5•11 years ago
|
||
Works great: https://tbpl.mozilla.org/?tree=Try&rev=e52bcf945dcd
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Component: Tools → General
You need to log in
before you can comment on or make changes to this bug.
Description
•