969991 - Add jittest to trychooser

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Phil Ringnalda (:philor)]

But beware bug 969988 while testing, and use something other than linux32/linux64 as the builder.

Comment 1

[Dan Minor [:dminor]]

Attachment: Add jittest to try chooser.

Another option would be to do something similar to how mochitests are handled (mochitests or mochitest-1, etc.) but I'm not sure that is any less messy.

Comment 2

[[e-mail] (:bhearsum)]

Comment on attachment 8397303 [details] [diff] [review]
Add jittest to try chooser.

Review of attachment 8397303 [details] [diff] [review]:
-----------------------------------------------------------------

I don't know this code very well, but I don't know who else to give this to...

Comment 3

[Phil Ringnalda (:philor)]

Adding another bit like http://mxr.mozilla.org/build/source/buildbotcustom/try_parser.py#16 would turn this from a miserable pain in the ass ("I chose -u jittest, but it didn't even run on Linux!") into a tolerable thing.

Comment 4

[Dan Minor [:dminor]]

Attachment: Make jittests match multiple jittest suites in buildbotcustom.

Following philor's suggestion to make this a tolerable pain in the ass.

Comment 5

[Dan Minor [:dminor]]

Assuming the second patch is ok, maybe the first patch should just add a checkbox for jittests to run everything. Breaking out the jittest suites for linux as options might be more confusing than helpful.

Comment 6

[Phil Ringnalda (:philor)]

Nope, you still need to have the explicit checkboxes for the parts, and this is (part of) why we should stop splitting things differently per-OS, per-debug/opt on a single OS, and every other which way we can think of splitting things every time we turn around: if your patch gets backed out for failing jittest-2, not jittest but jittest-2, you should not have to know that jittest+Linux will run exactly the jittest-2 that you have to run.

Comment 7

[Dan Minor [:dminor]]

Thanks!
Pushed buildbotcustom patch here: https://hg.mozilla.org/build/buildbotcustom/rev/e9a52c460141
and trychooser patch here: https://hg.mozilla.org/build/tools/rev/9be42dbbcb54

Comment 8

[John Hopkins (:jhopkins)]

in production.

Comment 9

[Dan Minor [:dminor]]

Working as expected.