This patch is not in 1.4, which provides a UI switch to turn on MLS geolocation logs: bug 1011410. There is a a preference in NetworkGeolocationProvider.js that is supposed to turn on logging, it is no longer working. Without logs on geolocation bugs, they are extremely difficult to fix. Previously, to turn on logging on b2g one could do the following: adb root adb pull /system/b2g/defaults/pref/user.js . echo 'pref("geo.wifi.logging.enabled", true);' >> user.js adb remount adb push user.js /system/b2g/defaults/pref adb shell sync && adb reboot The preference is still in the code, it is just not being respected: http://mxr.mozilla.org/mozilla-b2g30_v1_4/source/dom/system/NetworkGeolocationProvider.js
Looks like this patch caused it: https://bugzilla.mozilla.org/show_bug.cgi?id=1022279 This code is causing the pref to set back to false on startup: http://mxr.mozilla.org/mozilla-b2g30_v1_4/source/dom/system/NetworkGeolocationProvider.js#140, if (name == SETTINGS_DEBUG_ENABLED) should be changed to if (name == SETTINGS_DEBUG_ENABLED && !gLoggingEnabled) On startup of this provider, let the js pref override the UI setting.
Created attachment 8453134 [details] [diff] [review] 1036110-Stop-UI-setting-from-overriding-js-prefs.patch On startup, stop the B2G UI setting from overriding the js prefs setting, and turning off logging. If gLoggingEnabled is already on during startup, that means it was set in js prefs. Doug, you were involved in prefs stuff in this file recently, marking it for your review.
https://hg.mozilla.org/integration/b2g-inbound/rev/d7078fde6b33 Garvan says this affects all branches, so setting status flags accordingly.
Assignee: nobody → gkeeley
blocking-b2g: --- → 1.4?
status-b2g-v2.0: fixed → affected
status-b2g-v2.1: --- → affected
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S6 (18july)
status-b2g-v1.4: affected → fixed
status-b2g-v2.0: affected → fixed
status-b2g-v2.1: affected → fixed
status-firefox31: --- → wontfix
status-firefox32: --- → fixed
status-firefox33: --- → fixed
You need to log in before you can comment on or make changes to this bug.