Closed Bug 1036110 Opened 6 years ago Closed 6 years ago

[1.4] Geolocation: geo.wifi.logging.enabled not respected, can't get logs

Categories

(Firefox OS Graveyard :: General, defect)

All
Gonk (Firefox OS)
defect
Not set

Tracking

(blocking-b2g:1.4+, firefox31 wontfix, firefox32 fixed, firefox33 fixed, b2g-v1.4 fixed, b2g-v2.0 fixed, b2g-v2.1 fixed)

RESOLVED FIXED
2.0 S6 (18july)
blocking-b2g 1.4+
Tracking Status
firefox31 --- wontfix
firefox32 --- fixed
firefox33 --- fixed
b2g-v1.4 --- fixed
b2g-v2.0 --- fixed
b2g-v2.1 --- fixed

People

(Reporter: garvan, Assigned: garvan)

References

Details

Attachments

(1 file)

This patch is not in 1.4, which provides a UI switch to turn on MLS geolocation logs: bug 1011410.

There is a a preference in NetworkGeolocationProvider.js that is supposed to turn on logging, it is no longer working. Without logs on geolocation bugs, they are extremely difficult to fix.

Previously, to turn on logging on b2g one could do the following:
adb root
adb pull /system/b2g/defaults/pref/user.js .
echo 'pref("geo.wifi.logging.enabled", true);' >> user.js 
adb remount
adb push user.js /system/b2g/defaults/pref
adb shell sync && adb reboot

The preference is still in the code, it is just not being respected:
http://mxr.mozilla.org/mozilla-b2g30_v1_4/source/dom/system/NetworkGeolocationProvider.js
Blocks: mls-dolphin
Depends on: 1011410
Hardware: x86 → All
Looks like this patch caused it: https://bugzilla.mozilla.org/show_bug.cgi?id=1022279

This code is causing the pref to set back to false on startup:
http://mxr.mozilla.org/mozilla-b2g30_v1_4/source/dom/system/NetworkGeolocationProvider.js#140,

if (name == SETTINGS_DEBUG_ENABLED) should be changed to
if (name == SETTINGS_DEBUG_ENABLED && !gLoggingEnabled) 

On startup of this provider, let the js pref override the UI setting.
On startup, stop the B2G UI setting from overriding the js prefs setting, and  turning off logging. If gLoggingEnabled is already on during startup, that means it was set in js prefs. Doug, you were involved in prefs stuff in this file recently, marking it for your review.
Attachment #8453134 - Flags: review?(dougt)
Attachment #8453134 - Flags: review?(dougt)
Attachment #8453134 - Flags: review+
Attachment #8453134 - Flags: approval-mozilla-b2g30+
Keywords: checkin-needed
https://hg.mozilla.org/integration/b2g-inbound/rev/d7078fde6b33

Garvan says this affects all branches, so setting status flags accordingly.
Assignee: nobody → gkeeley
blocking-b2g: --- → 1.4?
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/d7078fde6b33
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S6 (18july)
blocking-b2g: 1.4? → 1.4+
You need to log in before you can comment on or make changes to this bug.