1036110 - [1.4] Geolocation: geo.wifi.logging.enabled not respected, can't get logs

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[:garvan]

This patch is not in 1.4, which provides a UI switch to turn on MLS geolocation logs: bug 1011410.

There is a a preference in NetworkGeolocationProvider.js that is supposed to turn on logging, it is no longer working. Without logs on geolocation bugs, they are extremely difficult to fix.

Previously, to turn on logging on b2g one could do the following:
adb root
adb pull /system/b2g/defaults/pref/user.js .
echo 'pref("geo.wifi.logging.enabled", true);' >> user.js 
adb remount
adb push user.js /system/b2g/defaults/pref
adb shell sync && adb reboot

The preference is still in the code, it is just not being respected:
http://mxr.mozilla.org/mozilla-b2g30_v1_4/source/dom/system/NetworkGeolocationProvider.js

Comment 1

[:garvan]

Looks like this patch caused it: https://bugzilla.mozilla.org/show_bug.cgi?id=1022279

This code is causing the pref to set back to false on startup:
http://mxr.mozilla.org/mozilla-b2g30_v1_4/source/dom/system/NetworkGeolocationProvider.js#140,

if (name == SETTINGS_DEBUG_ENABLED) should be changed to
if (name == SETTINGS_DEBUG_ENABLED && !gLoggingEnabled) 

On startup of this provider, let the js pref override the UI setting.

Comment 2

[:garvan]

Attachment: 1036110-Stop-UI-setting-from-overriding-js-prefs.patch

On startup, stop the B2G UI setting from overriding the js prefs setting, and  turning off logging. If gLoggingEnabled is already on during startup, that means it was set in js prefs. Doug, you were involved in prefs stuff in this file recently, marking it for your review.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/d7078fde6b33

Garvan says this affects all branches, so setting status flags accordingly.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d7078fde6b33

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2ace7164be11
https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/2b648cedfc83