1036189 - Refactor gruntfile to chill out grunt watch &/or grunt connect:server on Landing Pages

Status: RESOLVED FIXED

(Webmaker Graveyard :: webmaker.org, defect)

Description

[Aki Rose Braun [:akirose]]

Worrying that my computer is going to take off while running this server is... not good. Should fix this.

Comment 1

[Aki Rose Braun [:akirose]]

Attachment: https://github.com/mozilla/webmaker-landing-pages/pull/13

Comment 2

[inactivate account for kate]

Comment on attachment 8456470 [details] [review]
https://github.com/mozilla/webmaker-landing-pages/pull/13

Nice! Looks like travis is failing btw, take a look at that before landing

Comment 3

[Aki Rose Braun [:akirose]]

There's actually a bug for that, bug #1036445. I have some theories on it, but haven't solved it. I have a workaround to lint/beautifuy locally before I merge to master though.

Comment 4

[Aki Rose Braun [:akirose]]

(for posterity's sake:)

[webmaker-landing-pages] grunt  10:52:05  ☁  1036189/better-server ☂ ⚡ ✭
Running "jsbeautifier:modify" (jsbeautifier) task
Beautified 2 files, changed 0 files...OK

Running "jshint:files" (jshint) task
>> 2 files lint free.

Running "htmlmin:build" (htmlmin) task

Running "imagemin:primary" (imagemin) task
✔ build/resources/img/sandstone/banner-maker-party.jpg (already optimized)
✔ build/resources/img/makersteps/graphic_remix.png (already optimized)
✔ build/resources/img/makersteps/graphic_thimble.png (already optimized)
✔ build/resources/img/sandstone/bg-gradient-sand.png (already optimized)
✔ build/resources/img/sandstone/bg-sand.png (already optimized)
✔ build/resources/img/makersteps/logo-makerparty.png (saved 2.21 kB - 47%)
✔ build/resources/img/sandstone/[e-mail] (already optimized)
✔ build/resources/img/makersteps/[e-mail] (already optimized)
✔ build/resources/img/logo.png (already optimized)
✔ build/resources/img/makersteps/[e-mail] (already optimized)
✔ build/resources/img/makersteps/[e-mail] (saved 4.55 kB - 47%)
✔ build/resources/img/sandstone/mozilla-wordmark-red.png (already optimized)
Minified 12 images (saved 6.77 kB)

Done, without errors.


Execution Time (2014-07-16 16:01:50 UTC)
loading tasks        126ms  ▇▇▇▇▇ 14%
jsbeautifier:modify  153ms  ▇▇▇▇▇▇ 17%
jshint:files          73ms  ▇▇▇ 8%
htmlmin:build        189ms  ▇▇▇▇▇▇▇▇ 21%
imagemin:primary     347ms  ▇▇▇▇▇▇▇▇▇▇▇▇▇▇ 39%
Total 889ms

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/webmaker-landing-pages

https://github.com/mozilla/webmaker-landing-pages/commit/fcbec36d4185646c709950603134fe4817b04e2b
Fixes Bug 1036189 - Refactor gruntfile to chill out grunt watch &/or grunt connect:server on Landing Pages

https://github.com/mozilla/webmaker-landing-pages/commit/cc25a5409591e68afab9d30cd08426be8ad6aabf
Merge pull request #13 from gesa/1036189/better-server

Fixes Bug 1036189 - Refactor gruntfile to chill out grunt watch &/or grunt connect:server on Landing Pages