Closed
Bug 1036288
Opened 11 years ago
Closed 11 years ago
Fix search box to 2 columns width instead of stretching all the way
Categories
(Firefox :: New Tab Page, defect)
Firefox
New Tab Page
Tracking
()
People
(Reporter: Mardak, Assigned: Mardak)
References
Details
Attachments
(1 file, 1 obsolete file)
5.13 KB,
patch
|
adw
:
review+
|
Details | Diff | Splinter Review |
From bug 1030832 ui spec, the search on new tab page is fixed to 2 columns instead of dynamically stretching to visible columns.
Flags: firefox-backlog+
Assignee | ||
Comment 1•11 years ago
|
||
Updated•11 years ago
|
QA Whiteboard: [qa+]
Updated•11 years ago
|
Iteration: 33.3 → ---
Comment 2•11 years ago
|
||
Comment on attachment 8452910 [details] [diff] [review]
v1
Review of attachment 8452910 [details] [diff] [review]:
-----------------------------------------------------------------
I think we should just hardcode the width in the CSS. Will that not work?
Attachment #8452910 -
Flags: review?(adw)
Assignee | ||
Comment 3•11 years ago
|
||
Using css removing js width code.
Attachment #8452910 -
Attachment is obsolete: true
Attachment #8458442 -
Flags: review?(adw)
Assignee | ||
Comment 4•11 years ago
|
||
Comment 5•11 years ago
|
||
Comment on attachment 8458442 [details] [diff] [review]
v2
Review of attachment 8458442 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks.
Attachment #8458442 -
Flags: review?(adw) → review+
Comment 6•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
Updated•11 years ago
|
Iteration: --- → 33.3
Updated•11 years ago
|
QA Contact: cornel.ionce
Comment 7•11 years ago
|
||
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:33.0) Gecko/20100101 Firefox/33.0
Mozilla/5.0 (X11; Linux i686; rv:33.0) Gecko/20100101 Firefox/33.0
Verified fixed on Windows 7 64bit, Mac OS X 10.9 and Ubuntu 14.04 using latest Nightly, build ID: 20140721030205.
Status: RESOLVED → VERIFIED
QA Whiteboard: [qa+] → [qa!]
You need to log in
before you can comment on or make changes to this bug.
Description
•