1036365 - Implement webelement#getElementRect to marionette

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[David Burns :automatedtester]

This will simplify getting the location and the size into 1 call

Comment 1

[David Burns :automatedtester]

https://tbpl.mozilla.org/?tree=Try&rev=3aa33f33eebd
https://tbpl.mozilla.org/?tree=Try&rev=4bd169ab7465

Comment 2

[David Burns :automatedtester]

Attachment: Implement element.rect to marionette for getting element size and location

Comment 3

[David Burns :automatedtester]

Attachment: Implement element.rect to marionette for getting element size and location

Comment 4

[Malini Das [:mdas] - Away, not checking bugmail]

Comment on attachment 8453696 [details] [diff] [review]
Implement element.rect to marionette for getting element size and location

Review of attachment 8453696 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, just unsure about scrollbars in chrome

::: testing/marionette/client/marionette/marionette.py
@@ +169,5 @@
> +
> +            * x and y represent the top left coordinates of the WebElement relative to top left corner of the document.
> +            * height and the width will contain the height and the width of the DOMRect of the WebElement.
> +
> +            The point (0, 0) refers to the top left corner of the document.

This line doesn't seem necessary, I think it's implied from the description of x and y. If you want to include it, you can add it in that description.

::: testing/marionette/marionette-server.js
@@ +1887,5 @@
> +            aRequest.parameters.id, this.getCurrentWindow());
> +        let clientRect = el.getBoundingClientRect();
> +        this.sendResponse({x: clientRect.x, y: clientRect.y,
> +                           width: clientRect.width, height: clientRect.height},
> +                          command_id);

is it possible to scroll in a chrome window/frame? If so, we should add the pageX/pageY offset to the returned x,y coordinates

Comment 5

[David Burns :automatedtester]

Attachment: Implement element.rect to marionette for getting element size and location

Comment 6

[David Burns :automatedtester]

updated patch after comments

Comment 7

[David Burns :automatedtester]

Attachment: Implement element.rect to marionette for getting element size and location

Comment 8

[David Burns :automatedtester]

This time with 100% more update

Comment 9

[David Burns :automatedtester]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fea261bd38e8

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fea261bd38e8

Comment 11

[Martijn Wargers (dead)]

There is no way in Marionette to get the element's location relative to the screen instead of the document, right?

Comment 12

[David Burns :automatedtester]

Martijn, use executeScript

Comment 13

[Andreas Tolfsen ❲:ato❳]

(In reply to Martijn Wargers [:mwargers] (QA) from comment #11)
> There is no way in Marionette to get the element's location relative to the
> screen instead of the document, right?

The correct approach would be to follow the algorithm outlined here:

https://w3c.github.io/webdriver/webdriver-spec.html#dfn-calculate-the-absolute-position

And add window.screenX and window.screenY to the result.

Practically this means you can use getElementRect, look at the x and y properties and add these numbers to screenX and screenY.