Closed
Bug 1036694
Opened 11 years ago
Closed 11 years ago
merge nsIMarkupDocumentViewer into nsIContentViewer
Categories
(Core :: DOM: Navigation, defect)
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: tbsaunde, Assigned: tbsaunde)
References
Details
(Keywords: addon-compat)
Attachments
(2 files)
53.30 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
34.55 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #8453433 -
Flags: review?(bugs)
Comment 2•11 years ago
|
||
Comment on attachment 8453433 [details] [diff] [review]
merge nsIMarkupDocumentViewer into nsIContentViewer
> [scriptable, builtinclass, uuid(0cb321bd-5b38-4586-8fcd-d43b366886fb)]
> interface nsIContentViewer : nsISupports
update uuid
>@@ -190,9 +192,86 @@ interface nsIContentViewer : nsISupports
> * case, if mParentWidget is null then this document should not even
> * be displayed.
> */
> [noscript,notxpcom,nostdcall] nsViewPtr findContainerView();
> /**
> * Set collector for navigation timing data (load, unload events).
> */
> [noscript,notxpcom,nostdcall] void setNavigationTiming(in nsDOMNavigationTimingPtr aTiming);
>+ /*
>+ Scrolls to a given DOM content node.
>+ */
>+ void scrollToNode(in nsIDOMNode node);
>+
>+ /** The amount by which to scale all text. Default is 1.0. */
>+ attribute float textZoom;
>+
>+ /** The amount by which to scale all lengths. Default is 1.0. */
>+ attribute float fullZoom;
>+
>+ /** Disable entire author style level (including HTML presentation hints) */
>+ attribute boolean authorStyleDisabled;
>+
>+ /**
>+ * XXX comm-central only: bug 829543. Not the Character Encoding menu in
>+ * browser!
>+ */
>+ attribute ACString forceCharacterSet;
>+
>+ /**
>+ * XXX comm-central only: bug 829543.
>+ */
>+ attribute ACString hintCharacterSet;
>+
>+ /**
>+ * XXX comm-central only: bug 829543.
>+ */
>+ attribute int32_t hintCharacterSetSource;
You have tabs here. Uses spaces, and make sure indentation is right above
Attachment #8453433 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Attachment #8454091 -
Flags: review?(bugs)
Comment 4•11 years ago
|
||
Comment on attachment 8454091 [details] [diff] [review]
fixup js users of nsIMarkupDocument
> function getCurrentZoom() {
> var contViewer = toolbox.frame.docShell.contentViewer;
>- var docViewer = contViewer.QueryInterface(Ci.nsIMarkupDocumentViewer);
>+ var docViewer = contViewer;
> return docViewer.fullZoom;
Just drop docViewer and do
return contViewer.fullZoom;
> setZoom: function(zoomValue) {
> // cap zoom value
> zoomValue = Math.max(zoomValue, MIN_ZOOM);
> zoomValue = Math.min(zoomValue, MAX_ZOOM);
>
> let contViewer = this.frame.docShell.contentViewer;
>- let docViewer = contViewer.QueryInterface(Ci.nsIMarkupDocumentViewer);
>+ let docViewer = contViewer;
>
> docViewer.fullZoom = zoomValue;
similar here.
Attachment #8454091 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 5•11 years ago
|
||
Assignee | ||
Comment 6•11 years ago
|
||
Comment 7•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b88aab9f4e80
https://hg.mozilla.org/mozilla-central/rev/7ce6d4ccc804
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Comment 8•11 years ago
|
||
A quick MXR search shows at least 20 AMO add-ons that use this interface. A deprecation path would have been nice.
Keywords: addon-compat
Comment 9•11 years ago
|
||
Trevor, could you perhaps add a dummy nsIMarkupDocumentViewer interface, which just inherits nsIContentViewer.
Comment 10•10 years ago
|
||
What about fixing the online documentation (such as https://developer.mozilla.org/en/Full_page_zoom)?
Comment 11•10 years ago
|
||
MDN is a wiki, feel free to fix incorrect information there.
(But yes, should probably check always if patches change something documented in MDN.)
Comment 12•8 years ago
|
||
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/6520f949f61c
merge nsIMarkupDocumentViewer into nsIContentViewer r=smaug
You need to log in
before you can comment on or make changes to this bug.
Description
•