1036788 - Stop using origins to identify apps

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[[:fabrice] Fabrice Desré]

I'm about to enable multiple apps per origin, so we'll have issues.

at least https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/app_window_manager.js#L47 and getApps() need to be fixed.

Comment 1

[(inactive after 6/18) Alive Kuo [:alive]]

Fabrice do you have a fix or need me to find someone in my team to work on it?

Comment 2

[[:fabrice] Fabrice Desré]

(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #1)
> Fabrice do you have a fix or need me to find someone in my team to work on
> it?

I don't have a fix so if someone can take this bug that would be great!

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

George, please take this after your blockers are fixed.

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Proposed change:

AppWindowManager.getApp is used by AppWindowFactory to see if an app is already opened.
We should change the argument of getApp to use manifestURL instead of origin.

Comment 7

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

waiting for test.

Comment 8

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8456015 [details] [review]
PR to master

Hi Alive,
could you review this patch? I think we need both manifestURL and origin to identify an app.

Comment 9

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8456015 [details] [review]
PR to master

Thanks.

Comment 10

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks,
master
https://github.com/mozilla-b2g/gaia/commit/a43c96bc4797bcc2b42dd58e2720347bb9e361a5

Comment 11

[Salvador de la Puente González [:salva]]

This patch solves a regression introduced in [1] which prevent the STK command for select an item to work. I'm going to file a bug with the STR to test it.

[1] https://github.com/mozilla-b2g/gaia/commit/5c0b52751c7cf9f73d44126916a822baf65e2547#diff-5a6489711b0f6e366fbefde28f3ce078R312