1037033 - Add ability to annotate manifest tests in blacklist

Status: RESOLVED FIXED

(Testing Graveyard :: JSMarionette, defect)

Description

[Kevin Grandon :kgrandon]

Currently there is no way to know which disabled test points to which bug. We should be able to document this in the manifest file.  I think changing blacklist to an array makes the most sense here. E.g., 

"blacklist": {
  "testfile.js" : "Bug 12345 - Whatever text I want here."
}

Comment 1

[Kevin Grandon :kgrandon]

Attachment: Pull request - add annotation support

Comment 2

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8453897 [details] [review]
Pull request - add annotation support

Works for me :)

Comment 3

[Gareth Aye [:gaye] (back from PTO)]

https://github.com/mozilla-b2g/marionette-js-runner/commit/177e625a1b10d6e948c1bee71ac36b1255ceb8f3 landed on master. kgrandon: you should sync up with dale so that all of y'alls patches to marionette-js-runner and marionette-js-logger can be published to npm and downstreamed to gaia in one go to minimize headaches

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8453897 [details] [review]
Pull request - add annotation support

Thanks Gareth. I'll follow-up with Dale about bump strategy.

Comment 5

[Kevin Grandon :kgrandon]

In node-modules: https://github.com/mozilla-b2g/gaia-node-modules/commit/2d98908bd8e93b5db1d1eff1b4424b620f3c9dc8

Comment 6

[Kevin Grandon :kgrandon]

And heading to master now: https://github.com/mozilla-b2g/gaia/pull/21639

Marking this as fixed. Thanks!