1037041 - [B2G][Flame][Music] Music app will not close after attempting to share through email in low memory environments

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Adam Alldredge [:AdamA][Inactive]]

Attachment: logcat

Description:
When attempting to share songs from the music app through email repeatedly the music app will become stuck on the screen and will not close.

Repro Steps:
1) Update a Flame device to BuildID: 20140710000201
2) Set Phone memory to 273mb
3) Open email app (sign into an email account if not already signed in)
4) Switch to music app
5) Start playing a song
6) Choose to share the song through email
7) Cancel email and return to email app
8) Repeat steps 6-7 until it does not switch to email app (usually 1-2 times)
9) Press Home button
10) Observe music app remaining on screen

Actual:
Music app remains on screen and will not close

Expected:
it is expected that users are able to exit the music app

Environmental Variables:
Device: Flame v2.0 (273mb) Moz ril
Build ID: 20140710000201
Gaia: 35a9b715e7348ec738ff6c8a59f50190390a06f2
Gecko: 94714370dfc3
Version: 32.0a2 (2.0)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0


Keywords: E-mail, lock, stuck.


Notes:
This issue occurs whether or not the song is able to attach to the email.


Repro frequency: 90%
See attached: video clip(http://youtu.be/7GTo6pXgNgA), logcat

--------------------------------------------------

This issue also occurs on Flame 2.1 (273mb).

Environmental Variables:
Device: Flame Master (273mb)
BuildID: 20140709040203
Gaia: 0f9f11d0a6dadb3ea27160204bbe911c1ad69a6f
Gecko: 196d05832e12
Version: 33.0a1 (Master) 
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Actual:
Music app remains on screen and will not close

--------------------------------------------------

This issue does not occur on Flame 2.0 (512mb), Flame 1.4, Buri 1.4, Buri 2.0, Buri 2.1, Open_C 1.4, Open_C 2.0, Open_C 2.1, Flame Base v122, Flame Base v121-2.


Environmental Variables:
Device: Flame 2.0 (512mb)
BuildID: 20140708000322
Gaia: e935f4ff190b76c70d9b2af8856c542a6e4a7546
Gecko: 3f9d7a3a0b7b
Version: 32.0a2 (2.0) 
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Environmental Variables:
Device: Flame 1.4
Build ID: 20140709003002
Gaia: b0e9b4bdb39c5eb93a6783a34624ffc84f62b126
Gecko: acf704e54e19
Version: 30.0 (1.4)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Environmental Variables:
Device: Flame 1.3
Build ID: 20140616171114
Gaia: e1b7152715072d27e0880cdc6b637f82fa42bf4e
Gecko: e181a36ebafaa24e5390db9f597313406edfc794
Version: 28.0 (1.3)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:28.0) Gecko/28.0 Firefox/28.0

Environmental Variables:
Device: Flame 1.3
Build ID: 20140610200025
Gaia: e106a3f4a14eb8d4e10348efac7ae6dea2c24657
Gecko: b637b0677e15318dcce703f0358b397e09b018af
Version: 28.0 (1.3)
Firmware Version: v121-2
User Agent: Mozilla/5.0 (Mobile; rv:28.0) Gecko/28.0 Firefox/28.0

Environmental Variables:
Device: Buri Master
Build ID: 20140709073020
Gaia: c394b7b4205b6f1a6ca44915fc08650f3ad127ec
Gecko: 2d88803a0b9c
Version: 33.0a1 (Master)
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Environmental Variables:
Device: Buri 2.0
Build ID: 20140709063007
Gaia: 1774027323bb072b4ebdfea9883572bcf2535c87
Gecko: 11b6493a7d8f
Version: 32.0a2 (2.0)
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Environmental Variables:
Device: Buri 1.4
Build ID: 20140709003002
Gaia: b0e9b4bdb39c5eb93a6783a34624ffc84f62b126
Gecko: acf704e54e19
Version: 30.0 (1.4)
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Environmental Variables:
Device: Open_C Master
Build ID: 20140708040218
Gaia: 740faa5d0060fb218b407cf224330654ddf833a5
Gecko: 465280604ea6
Version: 33.0a1 (Master)
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Environmental Variables:
Device: Open_C 2.0
Build ID: 20140708000322
Gaia: e935f4ff190b76c70d9b2af8856c542a6e4a7546
Gecko: 3f9d7a3a0b7b
Version: 32.0a2 (2.0)
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Environmental Variables:
Device: Open_C 1.4
Build ID: 20140709000201
Gaia: b0e9b4bdb39c5eb93a6783a34624ffc84f62b126
Gecko: acf704e54e19
Version: 30.0 (1.4)
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Actual:
Music app closes and other actions can be performed

Comment 1

[KTucker [:KTucker][Inactive 3/4/2016]]

This is a regression from 1.4 and the user will not be able to close the music app after encountering this issue. Nominating this 2.0?

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

George could you take and investigate this one?

Comment 3

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

B2g-inbound Regression Window

Last working
Environmental Variables:
Device: Flame Master
BuildID: 20140604084216
Gaia: 2a4c7becdb141d2601e47a040a27eebe52a8db79
Gecko: fd5bb34861d6
Version: 32.0a1 (Master)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0


First Broken
Environmental Variables:
Device: Flame Master
BuildID: 20140604105916
Gaia: 18e2e8dc2d9ff19cd1210026367c14956d04eb0d
Gecko: c36c5f011229
Version: 32.0a1 (Master)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0


Last working gaia / First broken gecko - Issue does NOT occur
Gaia: 2a4c7becdb141d2601e47a040a27eebe52a8db79
Gecko: c36c5f011229

First broken gaia / Last working gecko - Issue DOES occur
Gaia: 18e2e8dc2d9ff19cd1210026367c14956d04eb0d
Gecko: fd5bb34861d6

Gaia Pushlog:  https://github.com/mozilla-b2g/gaia/compare/2a4c7becdb141d2601e47a040a27eebe52a8db79...18e2e8dc2d9ff19cd1210026367c14956d04eb0d

Comment 4

[Joshua Mitchell (Inactive)]

Jason - nothing in this pushlog covers Email or Music apps, is it possible this could be Vertical Homescreen related?

Comment 5

[(Inactive after June) George Duan [:gduan] [:喬智]]

I found "07-10 10:25:39.230: E/GeckoConsole(291): [JavaScript Error: "TypeError: this.element is null" {file: "app://system.gaiamobile.org/js/app_window.js" line: 300}]" in the attachment, however , It looks like the bug is 'ONLY' reproducible on "273MB FLAME".

So I followed below instruction to reset my flame as 273MB
*** 1) adb reboot bootloader
*** 2) sudo fastboot oem mem 273 // Set memory limit to  273MB, 0 is auto(default)
*** 3) sudo fastboot getvar mem // Check if memory is set correctly
*** 4) sudo fastboot reboot.

Now, I can reproduce it after 273MB is set, but I can't find any gaia failure now.
Still investigating.

Comment 6

[Kevin Grandon :kgrandon]

I can't really see anything in that gaia pushlog, I don't think it's homescreen specific.

I also don't really understand the regression ranges here. "Last working gaia / First broken gecko" - it says that this does not reproduce the issue? What does "First broken gecko" refer to in this case?

Comment 7

[(Inactive after June) George Duan [:gduan] [:喬智]]

Followed with comment 5,
I can see the log as below now.
[JavaScript Error: "TypeError: this.element is null" {file: "app://system.gaiamobile.org/js/app_window.js" line: 300}]" in the attachment, however , It looks like the bug is 'ONLY' reproducible on "273MB FLAME".

but the line failed at 
https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/app_window.js#L1402

I think when we discard the mail and switch back to music, gecko print out memory pressure and kill the background app (email), because I can't find email process while doing 2nd time switching from email.

Comment 8

[(Inactive after June) George Duan [:gduan] [:喬智]]

Sorry, should be failed at this line
https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/app_window.js#L303

Comment 9

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: First time launch email through music app

Comment 10

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: Second time launch email through music app

Followed with comment 7,

When I set DEBUG as true to see full log of app_window.js, system app has actually handled handle_mozbrowsererror while email is killed, so system should have already done relaunch email activity.

I compare these two log file, first one is first time sharing music to email and second one is 2nd time sharing music to email, and I found there's only one log missing as below

07-15 07:25:17.809: E/GeckoConsole(299): Content JS LOG at app://system.gaiamobile.org/js/app_window.js:963 in aw_debug: [Dump: HomescreenWindow][Home screen][homescreen][40490.419] fade out >>>> 

and I also print out b2g-ps, I found homescreen is not in the list.

Comment 11

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

Hi Alive, 
could you take a look of my patch?
I think the root cause is the homescreen is killed in background due to memory pressure, and system do homescreen.fadeOut for some reason while launching activity. I think we should check this.element before doing that.

Comment 12

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8455997 [details] [review]
PR to master

Cool, test please.

Comment 14

[(Inactive after June) George Duan [:gduan] [:喬智]]

Test added,
Thanks Alive.

Tbpl passed,
https://tbpl.mozilla.org/?rev=cdbee5ae54ee4e64cd446d56574144f8906c7470&tree=Gaia-Try

merge to master,
https://github.com/mozilla-b2g/gaia/commit/71cdbd38bc9321b53fa4d3004650512e871cc0d8

Comment 15

[Joshua Mitchell (Inactive)]

Issue has been resolved, removing unneeded QA-Wanted tags.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/363e32deb090554ec27a4164f5c5a5b941b9037b

Comment 19

[James Zhang (Spreadtrum)]

We need this patch.
Without this patch, we will meet homescreen no icon issue when monkey test.

Comment 20

[James Zhang (Spreadtrum)]

Attachment: jietu1.png

gaia debug snapshot

Comment 21

[James Zhang (Spreadtrum)]

Attachment: index.png

homescreen snapshot

Comment 22

[yang.zhao]

With your patch and the STR in comment 0, I still could reproduce the issue on dolphin, it stays in music and couldn't go back to homescreen. I find the following error:
E/GeckoConsole(  107): [JavaScript Error: "TypeError: this.app.element is null" {file: "app://system.gaiamobile.org/js/app_transition_controller.js" line: 156}]

The error is printed in _do_opening,please see the codes:

149   AppTransitionController.prototype._do_opening =
150     function atc_do_opening() {
151       this._openingTimeout = window.setTimeout(function() {
152         this.app.broadcast('openingtimeout');
153       }.bind(this),
154       System.slowTransition ? this.SLOW_TRANSITION_TIMEOUT :
155                               this.TRANSITION_TIMEOUT);
156       this.app.element.classList.add('transition-opening');
157       this.app.element.classList.add(this.getAnimationName('open'));
158     };

I think we should resolve this error,too.Maybe we should check this.app.element in this file.Could you give me some suggestions? Thank you!

Comment 23

[Peipei Cheng (needinfo if you need my action)]

Yang/James, I don't understand why you want to apply this patch in 1.4. Per comment 1 and comment 3, this is only reproducible on v2.0. V1.4 does not have this problem. The issue you saw in dolphin should be another issue.

Comment 24

[Rachelle Yang [:ryang][[e-mail]]]

Hi Yang and James, looks like this issue doesn't exit on Dolphin.Let's keep monitoring it.
Besides,Replying comment19, I don't think we need re-based 1.4 patch for Dolphin. 
This is the regression issue from 1.4 to 2.0, thus only v2.0 needs to be solved.
Thanks.

Comment 25

[yang.zhao]

(In reply to Peipei Cheng from comment #23)
> Yang/James, I don't understand why you want to apply this patch in 1.4. Per
> comment 1 and comment 3, this is only reproducible on v2.0. V1.4 does not
> have this problem. The issue you saw in dolphin should be another issue.
Hi,peipei
  I test both WITH the patch and WITHOUT the patch, dolphin could reproduce the issue with the same log in comment 22.When the issue occurs,both music and homescreen are in foreground,and you couldn't back to homescreen. Although the result is the same, the root cause may be not the same. So maybe it's another issue.Thank you.

Comment 26

[Shine(Leave from Mozilla)]

Attachment: video

This issue has been verified successfully on Flame 2.0 and 2.1
See attachment: Verify_1037041.MP4
Reproducing rate: 0/15
Flame 2.0 build:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141130000204
Version         32.0

Flame 2.1 build:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141130001203
Version         34.0