Move remote debugging options into submenu

NEW
Unassigned

Status

Firefox OS
Gaia::Settings
4 years ago
6 months ago

People

(Reporter: jryans, Unassigned)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

In bug 1000407, a (currently hidden) option was added to control DevTools via WiFi.  So the debugging options now look like this:

Debugging via USB (menu)

( ) Disabled
( ) ADB only
( ) ADB and DevTools

DevTools via WiFi ( ) (check box)

In bug 1033079, :pauljt mentioned that a goal of the "via USB" menu was to have one master switch that could turn off everything.  In bug 1033079 comment 15 and bug 1033079 comment 16, he suggest some ways to go back to a master switch by using a submenu.

I'll copy / reply to his comments in this bug.
(Reporter)

Comment 1

4 years ago
(In reply to Paul Theriault [:pauljt] from comment #15)
> (In reply to J. Ryan Stinnett [:jryans] from comment #13)
> > Another wrinkle that led to the current choice of independent options on
> > Firefox OS is that the USB DevTools option is bundled in a menu with ADB as
> > well.  So, what Jan and I thought would be most clear was:
> > 
> > Debugging via USB (menu)
> > 
> > ( ) Disabled
> > ( ) ADB only
> > ( ) ADB and DevTools
> > 
> > DevTools via WiFi ( ) (check box)
> > 
> > since WiFi DevTools are unrelated to the others.
> 
> I'm probably bikeshedding here, but part of the reason we merged this
> initially was to have ONE switch for turning debugging off or on.
> 
> Can we use a UI similar to the Wifi hotspot UI
> 
> Remote Debugging (on/off toggle)
> Debugging Options ...
> 
> Where the "Debugging Options..." opens a options dialog which has:
> 
> adb ( )
> Devtools via adb ( ) - greyed out if adb is disabled
> Devtoosl via wifi ( )
> 
> The main reason why I prefer this is that we could disable remote debugging
> without messing with the developers debugging preferences. Also, when we
> display the persistent notification in the address bar, tapping on the
> notification takes you to one place where you can turn off remote debugging.
> Rather than having to work out which one is on, and which one you need to
> turn off.
(Reporter)

Comment 2

4 years ago
(In reply to Paul Theriault [:pauljt] from comment #16)
> PS this Debugging Options could be place to put a checkbox to disable the
> timeout e.g:
> 
> Debugging options:
>  adb (x)
>  Devtools via adb (x)
>  Devtoosl via wifi (x)
> Security options:
>  Disable debugging after 12 hours of inactivity (x)
>  Prevent debugging when device is locked (x)

Yes, I think it would be great to expose these additional controls!  We may want to do it in a followup bug, but I think it's good to at least note this here for additional context.
(Reporter)

Updated

4 years ago
See Also: → bug 998328
See Also: → bug 1035437, bug 1035423
(Reporter)

Updated

3 years ago
Blocks: 1142741
No longer blocks: 1027454
You need to log in before you can comment on or make changes to this bug.