Closed Bug 1027454 (wifi-rdp-on) Opened 5 years ago Closed 5 years ago

Enable WiFi debugging for Firefox OS by default

Categories

(DevTools :: WebIDE, defect)

defect
Not set

Tracking

(firefox39 fixed)

RESOLVED FIXED
Firefox 39
Tracking Status
firefox39 --- fixed

People

(Reporter: jryans, Assigned: jryans)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file, 1 obsolete file)

In bug 962308, we track the work to build an initial version of WiFi debugging.

Here, we track everything left over to finally enable it by default.
Alias: wifi-rdp-on
Depends on: 1027456
Depends on: 1027457
Depends on: 1027787
Depends on: 1031045
Depends on: 1031111
Depends on: 1032670
Depends on: 1034411
Depends on: 1037129
Depends on: 1037138
Depends on: 1039449
Depends on: 1044108
Depends on: 1046897
Depends on: 1109285
Depends on: 1022698
Depends on: 1128978
Depends on: 1130084
Depends on: 1130091
Depends on: 1132063
Depends on: 1142730
No longer depends on: 1031045
No longer depends on: 1027457
No longer depends on: 1034411
No longer depends on: 1109285
No longer depends on: 1128978
No longer depends on: 1130091
No longer depends on: 1132063
No longer depends on: 1037129
No longer depends on: 1046897
No longer depends on: 1037138
Attached file MozReview Request: bz://1027454/jryans (obsolete) —
/r/5785 - Bug 1027454 - Enable WiFi debugging by default. r=past,janx

Pull down this commit:

hg pull review -r 56d55a8ced2bc9675ccd672be321c2a6a593da1e
Attachment #8580566 - Flags: review?(past)
Attachment #8580566 - Flags: review?(janx)
Comment on attachment 8580566 [details]
MozReview Request: bz://1027454/jryans

https://reviewboard.mozilla.org/r/5783/#review4749

Ship It!
Attachment #8580566 - Flags: review?(past) → review+
Comment on attachment 8580566 [details]
MozReview Request: bz://1027454/jryans

I'm going to say "go", but I noticed a few problems:

- Bug 1130084 seems to be back.

- There seemed to be many more devtools errors in the logs when using over Wi-Fi, although it doesn't seem to happen consistently (I couldn't reproduce when I was trying to grab a copy of the offending logs).
Attachment #8580566 - Flags: review?(janx) → review+
Also, I wonder if you have a try push with the scanning enabled?
(In reply to Jan Keromnes [:janx] from comment #4)
> Also, I wonder if you have a try push with the scanning enabled?

Yes, sorry, forgot to post it!

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bfc07e6316d5
(In reply to Jan Keromnes [:janx] from comment #3)
> Comment on attachment 8580566 [details]
> MozReview Request: bz://1027454/jryans
> 
> I'm going to say "go", but I noticed a few problems:
> 
> - Bug 1130084 seems to be back.

Okay, I'll try to take another look at this one.

> - There seemed to be many more devtools errors in the logs when using over
> Wi-Fi, although it doesn't seem to happen consistently (I couldn't reproduce
> when I was trying to grab a copy of the offending logs).

Did you notice that features appeared to actually break?  Or just that more errors were logged?
Flags: needinfo?(janx)
(In reply to J. Ryan Stinnett [:jryans] from comment #6)
> > - Bug 1130084 seems to be back.
> 
> Okay, I'll try to take another look at this one.

Great! However, I don't consider this to be a blocker. Feel free to land the patch.

> Did you notice that features appeared to actually break?  Or just that more
> errors were logged?

I didn't actually see something break, but from what I remember the inspector was having trouble with certain nodes/properties(?). It might just be that the inspector is not used to increased delays, or it is subject to race conditions, because using it over Wi-Fi makes some things really sloooow (e.g. unfolding DOM nodes).
Flags: needinfo?(janx)
Keywords: dev-doc-needed
Blocks: 958755
Okay, all known blockers resolved.

Let's turn it on!

https://hg.mozilla.org/integration/fx-team/rev/82e0b5eda921
https://hg.mozilla.org/mozilla-central/rev/82e0b5eda921
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
I blogged about this new feature[1].  Some of the material may be useful when we update MDN too.

[1]: http://convolv.es/blog/2015/03/25/wifi-debug-fxos/
Summary: Enable WiFi debugging by default → Enable WiFi debugging for Firefox OS by default
Attachment #8580566 - Attachment is obsolete: true
Attachment #8618179 - Flags: review+
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.