1027454 - (wifi-rdp-on) Enable WiFi debugging for Firefox OS by default

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

In bug 962308, we track the work to build an initial version of WiFi debugging.

Here, we track everything left over to finally enable it by default.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: MozReview Request: bz://1027454/jryans

/r/5785 - Bug 1027454 - Enable WiFi debugging by default. r=past,janx

Pull down this commit:

hg pull review -r 56d55a8ced2bc9675ccd672be321c2a6a593da1e

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8580566 [details]
MozReview Request: bz://1027454/jryans

https://reviewboard.mozilla.org/r/5783/#review4749

Ship It!

Comment 3

[Jan Keromnes [:janx]]

Comment on attachment 8580566 [details]
MozReview Request: bz://1027454/jryans

I'm going to say "go", but I noticed a few problems:

- Bug 1130084 seems to be back.

- There seemed to be many more devtools errors in the logs when using over Wi-Fi, although it doesn't seem to happen consistently (I couldn't reproduce when I was trying to grab a copy of the offending logs).

Comment 4

[Jan Keromnes [:janx]]

Also, I wonder if you have a try push with the scanning enabled?

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Jan Keromnes [:janx] from comment #4)
> Also, I wonder if you have a try push with the scanning enabled?

Yes, sorry, forgot to post it!

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bfc07e6316d5

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Jan Keromnes [:janx] from comment #3)
> Comment on attachment 8580566 [details]
> MozReview Request: bz://1027454/jryans
> 
> I'm going to say "go", but I noticed a few problems:
> 
> - Bug 1130084 seems to be back.

Okay, I'll try to take another look at this one.

> - There seemed to be many more devtools errors in the logs when using over
> Wi-Fi, although it doesn't seem to happen consistently (I couldn't reproduce
> when I was trying to grab a copy of the offending logs).

Did you notice that features appeared to actually break?  Or just that more errors were logged?

Comment 7

[Jan Keromnes [:janx]]

(In reply to J. Ryan Stinnett [:jryans] from comment #6)
> > - Bug 1130084 seems to be back.
> 
> Okay, I'll try to take another look at this one.

Great! However, I don't consider this to be a blocker. Feel free to land the patch.

> Did you notice that features appeared to actually break?  Or just that more
> errors were logged?

I didn't actually see something break, but from what I remember the inspector was having trouble with certain nodes/properties(?). It might just be that the inspector is not used to increased delays, or it is subject to race conditions, because using it over Wi-Fi makes some things really sloooow (e.g. unfolding DOM nodes).

Comment 8

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Okay, all known blockers resolved.

Let's turn it on!

https://hg.mozilla.org/integration/fx-team/rev/82e0b5eda921

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/82e0b5eda921

Comment 10

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

I blogged about this new feature[1].  Some of the material may be useful when we update MDN too.

[1]: http://convolv.es/blog/2015/03/25/wifi-debug-fxos/

Comment 11

[Will Bamberg [:wbamberg]]

-> https://developer.mozilla.org/en-US/docs/Tools/WebIDE/Setting_up_runtimes#Connecting_over_WiFi

Comment 13

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: MozReview Request: Bug 1027454 - Enable WiFi debugging by default. r=past,janx