1037146 - The "show password" check box in the wifi connection details page in the FTU app is cut off on the right edge in RTL mode and label is cut off too

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[(no longer active)]

In addition to that, the check box appears on the left side of the text too.

Comment 1

[Stephany Wilkes]

Assigning to Pavel. Pavel, please let me know if you need a UX spec for this.

Comment 2

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/master

Comment 3

[Ahmed Nefzaoui [:Nefzaoui]]

Hey Pavel
I just left few comments in the PR for now.
Can you please fix them?

Thanks :)

Comment 4

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

I miss few lines ... but I find new bug :) so thanks :) 
can you check it again?

Comment 5

[Ahmed Nefzaoui [:Nefzaoui]]

Comment on attachment 8467367 [details] [review]
patch for Gaia/master

Good to go
Thanks! :)

Comment 6

[Stephany Wilkes]

Comment on attachment 8467367 [details] [review]
patch for Gaia/master

Flagging Jenny for ui-review? on this patch.

Comment 7

[Jenny Lee]

Comment on attachment 8467367 [details] [review]
patch for Gaia/master

Looks good. But I wonder if Jacqueline should take a look since it's FTU? Tks!

Comment 8

[Stephany Wilkes]

Flagging Jacqueline to verify Jenny's ui-review+ on this RTL UI improvement.

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8467367 [details] [review]
patch for Gaia/master

Delegating review to Fernando.

Comment 10

[Fernando Campo (:fcampo)]

Comment on attachment 8467367 [details] [review]
patch for Gaia/master

I thought I had made a review of this days ago :S Guess my brain is not working very well, I need some days off.

Anyway, I'm assuming you are referring to the 'Show Password' checkbox (I don't remember any 'remember password'). Code looks good, and it works nicely, great job Pavel.

Only concern is that we are fixing two bugs in here (label cut off and check icon), and it could be hard to track in the future. But at the same time, they are related (RTL changes) and are really small, so I am ok with solving both at the same time, but on condition of changing bug description to track both changes.

So r+ for the code, but please change bug title and commit message before merging.

Thanks!

Comment 11

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Thanks :)

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/f672a2ba95701a82b416c4067d26c5b10dcec7fc

Comment 12

[Kevin Grandon :kgrandon]

The original landing of this bug did not contain the bug number or reviewers. This is painful in the case it causes problems or tracking down future issues. Reverted and re-landed with an updated commit name.

Revert: https://github.com/mozilla-b2g/gaia/commit/064046729c37ee6e022c68d06f191c7ee81fb50d
Re-landing: https://github.com/mozilla-b2g/gaia/commit/1aaa927d8014b0ad5753363293f29994e23bf09e

Ni? on Pavel for awareness.

Comment 13

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Hey Kevin, 
thanks and sorry for this one

Comment 14

[Jacqueline Savory [:jsavory] UX]

Removing flag since this is fixed and everything looks good.

Comment 15

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame 2.1 and 2.2.

Result: The "show password" check box and label are displayed properly.

Device: Flame 2.1 (319mb, KK, Full Flash)
BuildID: 20141202001201
Gaia: ccb49abe412c978a4045f0c75abff534372716c4
Gecko: 18fb67530b22
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 34.0 (2.1)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
  
Device: Flame 2.2 (319mb, KK, Full Flash)
BuildID: 20141202040207
Gaia: 725685831f5336cf007e36d9a812aad689604695
Gecko: 2c9781c3e9b5
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 37.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 16

[Peter Bylenga [:PBylenga]]

Mass Edit: adding the [rtl-meta]