Closed
Bug 1037261
Opened 11 years ago
Closed 10 years ago
[User Story] Soft home key should not span the bottom of screen in landscape
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(feature-b2g:2.1)
People
(Reporter: pdol, Assigned: markus)
References
Details
(Keywords: feature, Whiteboard: [ucid:System225][systemsfe][tako][2.1-feature-qa+])
User Story
As a user, when in landscape mode, I don't want the soft home key to span the bottom of the screen so that it doesn't use up lots of valuable real estate. Acceptance Criteria: 1. When in landscape mode, the soft home key matches the UX spec definition.
Attachments
(1 file, 1 obsolete file)
No description provided.
|
Assignee | |
Comment 1•11 years ago
|
||
Attached a patch that contains a subset of the propsed changes in Bug 1032768. It excludes the fullscreen and edge swipe changes.
Flags: needinfo?(etienne)
|
||
Comment 2•11 years ago
|
||
Awesome Markus, thanks!
I've opened a pull request with your patch rebased, it looks very good and works really well (even the edge gestures!).
I want to run the CI on it, but we're basically good to go :)
Attachment #8457997 -
Attachment is obsolete: true
Attachment #8458625 -
Flags: review+
Flags: needinfo?(etienne)
|
|
||
Updated•11 years ago
|
Assignee: nobody → markus.nilsson
|
|
||
Comment 3•11 years ago
|
||
Forgot to mention, I removed the css vars and fat arrows.
I'm not opposed to them but we should probably have a wider conversation on dev-gaia first and keep consistency on a per-file base.
|
|
||
Comment 4•10 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/9623e042c83df8e479e402e91bcb93f78174b318
Sorry for the delay, congrats Markus!
Cool to see 2.1 features landing.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Updated•10 years ago
|
Whiteboard: [ucid:System225, ft:systemsfe] → [ucid:System225][systemsfe][tako]
Target Milestone: --- → 2.1 S1 (1aug)
|
||
Updated•10 years ago
|
QA Whiteboard: [2.1-feature-qa+]
|
|
||
Updated•10 years ago
|
Flags: in-moztrap?(jsmith)
|
|
||
Updated•10 years ago
|
QA Contact: jsmith
|
|
||
Updated•10 years ago
|
QA Whiteboard: [2.1-feature-qa+]
Whiteboard: [ucid:System225][systemsfe][tako] → [ucid:System225][systemsfe][tako][2.1-feature-qa+]
|
|
||
Updated•10 years ago
|
Flags: in-moztrap?(jsmith) → in-moztrap-
QA Contact: jsmith
|
|
||
Comment 5•10 years ago
|
||
No plans for QA verification on Moz side since this is being developed by our partner, so marking verified here.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•