Closed Bug 1037330 Opened 6 years ago Closed 6 years ago

[TSF] Add new pref intl.tsf.force_enable and make intl.tsf.enable ignored on XP or WinServer 2k3

Categories

(Core :: Widget: Win32, defect)

x86_64
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

(Keywords: inputmethod)

Attachments

(1 file)

We should separate prefs for enabling TSF for XP/Server 2k3 and Vista or later.

On prior to Vista, its TSF framework and default TIPs work really different. Actually, Japanese IME vendors don't use TSF on prior to Vista.

Our implementation conforms to XP, however, it's too risky to enable TSF mode on XP in default settings. Additionally, official support of Win XP (i.e., security updates) already ended. So, we can say, it's not worthwhile to enable TSF on XP.

I think that we should add a separated pref for XP/2k3 and it shouldn't be enabled in default settings forever.
Summary: [TSF] Add new pref intl.tsf.force_enabled_on_xp → [TSF] Add new pref intl.tsf.force_enable_on_xp
Attached patch PatchSplinter Review
"intl.tsf.force_enable" is better.

And this patch removes the migration code which picks up legacy pref name. All testers using TSF mode should be already migrated by this code.
Attachment #8454342 - Flags: review?(jmathies)
Summary: [TSF] Add new pref intl.tsf.force_enable_on_xp → [TSF] Add new pref intl.tsf.force_enable and make intl.tsf.enable ignored on XP or WinServer 2k3
Do you anticipate people trying to use tsf on XP for something? I'm wondering if we should just declare it as an unsupported feature.
(In reply to Jim Mathies [:jimm] from comment #2)
> Do you anticipate people trying to use tsf on XP for something? I'm
> wondering if we should just declare it as an unsupported feature.

If somebody wants to use tablet PC which was released before WinVista, they might want to use TSF for pen input. Or, somebody might want to use speech input with non-PC devices. Then, supporting TSF provides better UX for them. Actually, some tablet PC users reported some bugs of TSF mode.

As far as I know, Gecko is the only browser whose TSF mode is available on XP.

Although, they shouldn't use WinXP anymore since its support has already ended. But we're still keeping to support WinXP officially. So, we shouldn't kill TSF support on XP.

I guess that our implementation level is already enough for pen or speech input because they must not need the complicated features like Japanese IME. However, Japanese IME needs very complicated support. That is the reason why we cannot enable TSF support in default settings yet.
Comment on attachment 8454342 [details] [diff] [review]
Patch

Review of attachment 8454342 [details] [diff] [review]:
-----------------------------------------------------------------

ok, sounds like it might be useful.
Attachment #8454342 - Flags: review?(jmathies) → review+
https://hg.mozilla.org/mozilla-central/rev/5a9f78740f9c
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.