1037328 - [TSF] Enable TSF mode in default settings in Nightly build

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(still sick)]

For preparing to fix bug 478029, we should enable TSF mode on non-release build for wider test.

I think that we should do it when we fix bug 496360.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(still sick)]

Oh, I find NIGHTLY_BUILD. Only enables TSF on Nightly build is better.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(still sick)]

Attachment: Patch

I'll request review when all blockers are fixed.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(still sick)]

FYI: If you know some bugs which should be fixed before enabling TSF in Nightly build, please let me know.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(still sick)]

Comment on attachment 8456660 [details] [diff] [review]
Patch

I landed the patches for bug 496360 and bug 1043182 on m-i. So, they'll be fixed on Nightly soon.

I believe that it is time to enable TSF only in Nightly build because there is no serious issue for using Nightly builds in daily use.

I tested roughly with the patched build on WinVista, 7, 8, and 8.1 with each major IME of CJKT. (Although, I'm not familiar with non-Japanese IME behavior.)

I'm not sure the difference between defined(NIGHTLY_BUILD) and !defined(RELEASE_BUILD), though. I think checking NIGHTLY_BUILD is enough for this bug.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(still sick)]

FYI: TSF is enabled only on Vista or later. TSF on XP and WinServer 2k3 isn't enabled with "intl.tsf.enable".

Comment 6

[Masatoshi Kimura [:emk]]

Comment on attachment 8456660 [details] [diff] [review]
Patch

FYI: !defined(RELEASE_BUILD) roughly means "Nightly and Aurora".

Comment 7

[Martijn Wargers (dead)]

Perhaps you could give some insight on how users could test TSF mode?
This can only be tested on Windows, right?
They have to install a 3rd-party IME that supports TSF? Is there one that can be easily used for testing?
Can it be tested with english characters typed, or is this especially used in combination with Asian characters?

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(still sick)]

(In reply to Martijn Wargers [:mwargers] (QA) from comment #7)
> This can only be tested on Windows, right?

Yes but Vista or later.

> They have to install a 3rd-party IME that supports TSF?

It's not right. Microsoft's IME for each language is TIP (Text Input Processor) of TSF. So, users can test TSF mode with installing one of languages which need IME to input text from keyboard.

Some old 3rd-party IME may not be TIP of TSF. Then, they are fallen back to IMM mode of Gecko.

FYI: TIP supports non-keyboard text input such as handwriting systems or speech input. However, I'm not sure actual products of them. So, I hope such tests will report our bugs.

> Is there one that can be easily used for testing?

So, if a tester can speak one of CJKT, they can test the IME behavior just adding the language from control panel. Otherwise, I'm not sure how to test it.

> Can it be tested with english characters typed, or is this especially used
> in combination with Asian characters?

TSF doesn't depend on language. However, as I said above, I'm not sure how to test it without CJKT IME.

FYI: I use Nightly in daily use. And I enable TSF mode for a couple of years. So, at least for Japanese people, they must not meet trouble with major function of IME except already reported bugs which is blocking bug 478029.

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(still sick)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ad532252ff9e

Thanks! According to the emk-san's comment, we should enable in Aurora with !defined(RELEASE_BUILD) next when we implement all features.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ad532252ff9e

Comment 11

[Alice0775 White]

TSF seems to trigger the problem with Changjie input software. 
see  http://forums.mozillazine.org/viewtopic.php?f=23&t=2858387