Closed
Bug 1037570
Opened 11 years ago
Closed 11 years ago
Remove gfxPath
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: jwatt, Assigned: jwatt)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
8.92 KB,
patch
|
mattwoodrow
:
review+
|
Details | Diff | Splinter Review |
Continuing on from bug 939589, we can now get rid of gfxPath now that bug 933019 is fixed.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8454578 -
Flags: review?(matt.woodrow)
|
|
Assignee | |
Updated•11 years ago
|
Blocks: Moz2Dification
|
|
Assignee | |
Comment 2•11 years ago
|
||
Can you mark as needs-landing once you review, Matt?
|
||
Updated•11 years ago
|
Attachment #8454578 -
Flags: review?(matt.woodrow) → review+
|
|
||
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 3•11 years ago
|
||
Matt, Johnathan, could you provide a try link here ?
|
|
||
Comment 4•11 years ago
|
||
Tomcat, it's a fairly trivial dead-code removal patch, I doubt we need a try push for it.
|
|
||
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
|
||
Comment 6•11 years ago
|
||
(In reply to Matt Woodrow (:mattwoodrow) from comment #4)
> Tomcat, it's a fairly trivial dead-code removal patch, I doubt we need a try
> push for it.
Per the policy announcement 2 months ago, we require them.
https://groups.google.com/d/msg/mozilla.dev.platform/9w0-Bh_3vVI/xWebYK64GdwJ
For a simple patch like this, even a basic "does it build?" sanity check would suffice.
You need to log in
before you can comment on or make changes to this bug.
Description
•