Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

(Blocks: 1 bug)

Trunk
mozilla33
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Continuing on from bug 939589, we can now get rid of gfxPath now that bug 933019 is fixed.
(Assignee)

Comment 1

5 years ago
Created attachment 8454578 [details] [diff] [review]
patch
Attachment #8454578 - Flags: review?(matt.woodrow)
(Assignee)

Updated

5 years ago
Blocks: 882109
(Assignee)

Comment 2

5 years ago
Can you mark as needs-landing once you review, Matt?
Attachment #8454578 - Flags: review?(matt.woodrow) → review+
Keywords: checkin-needed
Matt, Johnathan, could you provide a try link here ?
Tomcat, it's a fairly trivial dead-code removal patch, I doubt we need a try push for it.
https://hg.mozilla.org/mozilla-central/rev/665539a1bbb3
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
(In reply to Matt Woodrow (:mattwoodrow) from comment #4)
> Tomcat, it's a fairly trivial dead-code removal patch, I doubt we need a try
> push for it.

Per the policy announcement 2 months ago, we require them.
https://groups.google.com/d/msg/mozilla.dev.platform/9w0-Bh_3vVI/xWebYK64GdwJ

For a simple patch like this, even a basic "does it build?" sanity check would suffice.
You need to log in before you can comment on or make changes to this bug.