1037587 - Make debugger button state clearer

Status: RESOLVED WORKSFORME

(DevTools :: Debugger, defect)

Description

[Jim Michaels]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0 (Beta/Release)
Build ID: 20140605174243

Steps to reproduce:

depress button twice


Actual results:

can't tell if button is depressed or not, 3d look for gray buttons uses what looks like single color for gray on and one for gray off. 3d look for form controls commonly employs these 2 colors just on one state alone.


Expected results:

either 
- use a grey for off, and something with color for on so we can tell it's on
- use 3d look on buttons, which means shifting the image when depressed, changing the border thickness on some sides but not others
- use real form control buttons (simpler). you can customize those to heart's content with CSS.

Comment 1

[Eddy Bruel [:ejpbruel]]

It's not that unclear to me (dark gray means depressed, light gray means not depressed), but I do agree that having a color for depressed/active buttons would be clearer. However, I can imagine that some people would consider that a violation of the styling we use for the debugger, so I need some opinions here.

Cc'ing victor because he probably has opinions, and might know who else we should ask.

Comment 2

[Victor Porof [:vporof][:vp]]

Bgrins has better opinions than mine, especially since he worked on all of this.

Comment 3

[Eddy Bruel [:ejpbruel]]

Hi bgrins, any thoughts on this?

Comment 4

[Jim Michaels]

usually some forms of grey/gray are reserved for inactive/disabled.
a color could represent "on".

Comment 5

[Brian Grinstead [:bgrins]]

Jim, could you explain exactly which button(s) / states you are talking about in the debugger panel?  When I use the pause button, I see the following states:

1) Normal: blends in with toolbar
2) Hover: becomes grey
3) Active: darker grey.  Unfortunately the pause button is being activated on mousedown and doesn't really show the active state (this should probably be another bug)
4) Enabled: the icon swaps to a play image and there is a light blue background

Comment 6

[Jim Michaels]

it's much better now. so I would consider fixed.

Comment 7

[Panos Astithas (he/him) [:past] (please ni?)]

Closing per comment 6.