1037606 - The placeholder text shown when the list of contacts is empty is left aligned in RTL mode

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[(no longer active)]

This affects the icons too.  The call log pane has the same issue.

Comment 1

[Stephany Wilkes]

Assigning to Pavel to see if he can take this. Let me know if you need any UX guidance and we'll get you a spec. Pavel, if you cannot, please unassign and ni? me. Thanks!

Comment 2

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/master

Comment 3

[Ahmed Nefzaoui [:Nefzaoui]]

Comment on attachment 8467383 [details] [review]
patch for Gaia/master

Working as expected :)
However I left you a small comment that I'd love if we address it before merging.

Thanks!

Comment 4

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Thanks Ahmed,

I saw your comment but we can't remove this line:
https://github.com/mozilla-b2g/gaia/pull/22501#discussion-diff-15793341R596

because we have `body { text-align: center; }`

Comment 5

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Thanks :)

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/d8ba56f655acaf51d0d2e6435f03ecea41d3f167

Comment 6

[Yeojin Chung [:YeojinC]]

This issue STILL reproduces on Flame 2.1.

Result: The placeholder text is aligned properly in Contacts. However, it is still aligned left to right on Call log and Messages app. New bug 1106930 is filed.

Device: Flame 2.1 (319mb, KK, Full Flash)
BuildID: 20141202001201
Gaia: ccb49abe412c978a4045f0c75abff534372716c4
Gecko: 18fb67530b22
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 34.0 (2.1)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 7

[Peter Bylenga [:PBylenga]]

Mass Edit: adding the [rtl-meta]

Comment 8

[Elie]

This issue does NOT exist on Flame 2.2
Gaia-Rev        f5b3d1b6cfa3e702033f613915ae637cb735cbfb
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/bccee1a13ba6
Build-ID        20150119002502
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
Reproduce rate 0/5
Refer to Video VIDEO0260.mp4

Comment 9

[Elie]

Attachment: VIDEO0260.mp4

Comment 10

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

This issue is verified fixed on Flame 3.0

The placeholder text is right aligned in RTL languages as expected

Environmental Variables:
Device: Flame 3.0 (319mb)(Kitkat)(Full Flash)
Build ID: 20150205010209
Gaia: 2b83a6d5d1185a438b5bbd287497ac2743b501db
Gecko: 34a66aaaca81
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0