H.264 SDP code doesn't find the correct fmtp value when negotiating if only mode 1 is supported

RESOLVED FIXED in Firefox 32, Firefox OS v2.0

Status

()

Core
WebRTC: Signaling
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jesup, Assigned: jesup)

Tracking

(Blocks: 2 bugs)

33 Branch
mozilla33
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(blocking-b2g:2.0+, firefox31 wontfix, firefox32 fixed, firefox33 fixed, b2g-v2.0 fixed, b2g-v2.1 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8454651 [details] [diff] [review]
H.264 mode 1-only support

This patch both turns off mode 0 (since we don't actually support it yet), and fixes a bug when an offer you're making an answer to only has mode 1 (it was failing to find the right fmtp entry when checking the packetization-mode value).

We'll want to uplift this to Aurora/32/2.0 so it can respond correctly to offers with mode 1 only (which is what we will generate).
Attachment #8454651 - Flags: review?(ethanhugg)

Comment 1

3 years ago
Comment on attachment 8454651 [details] [diff] [review]
H.264 mode 1-only support

Review of attachment 8454651 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm
Attachment #8454651 - Flags: review?(ethanhugg) → review+
(Assignee)

Comment 2

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/dac114b593f0
Blocks: 948160, 1003040
Target Milestone: --- → mozilla33
(Assignee)

Comment 3

3 years ago
We need this for 2.0 - first, we're offering mode 0 and don't actually support it.  Second, if offered h.264 mode-1 only, it would fail to connect video at all (and with this on inbound, we will only offer mode 1 from desktop).

It can be tested with http://mozilla.github.com/webrtc-landing/pc_test_h264.html

Updated

3 years ago
blocking-b2g: 2.0? → 2.0+
https://hg.mozilla.org/mozilla-central/rev/dac114b593f0
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
https://hg.mozilla.org/releases/mozilla-aurora/rev/ee3c7413a1f3
status-b2g-v2.0: --- → fixed
status-b2g-v2.1: --- → fixed
status-firefox31: --- → wontfix
status-firefox32: --- → fixed
status-firefox33: --- → fixed
(Assignee)

Updated

3 years ago
Whiteboard: [webrtc-uplift]
You need to log in before you can comment on or make changes to this bug.