Closed Bug 1037795 Opened 5 years ago Closed 5 years ago

Port Bug 1034360 to TB - remove OCSP preference UI (or at least remove the unnecessary dialog window)

Categories

(Thunderbird :: Preferences, defect)

defect
Not set

Tracking

(thunderbird34 fixed)

RESOLVED FIXED
Thunderbird 34.0
Tracking Status
thunderbird34 --- fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file, 1 obsolete file)

M-c removed the OCSP dialog (toolkit/mozapps/preferences/ocsp.xul) and now the "Verify" button is no more working.
Attached patch OCSP.patch (obsolete) — Splinter Review
This patch copies the changes from m-c to mail. I also changed some accesskeys to use the same as Firefox. I haven't changed  the accesskey ids as this change needs not to be propagated to the locales.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8454880 - Flags: review?(mkmelin+mozilla)
Comment on attachment 8454880 [details] [diff] [review]
OCSP.patch

Review of attachment 8454880 [details] [diff] [review]:
-----------------------------------------------------------------

Great, r=mkmelin

::: mail/components/preferences/advanced.xul
@@ +433,5 @@
> +                        label="&enableOCSP.label;"
> +                        accesskey="&enableOCSP.accesskey;"
> +                        onsyncfrompreference="return gAdvancedPane.readEnableOCSP();"
> +                        onsynctopreference="return gAdvancedPane.writeEnableOCSP();"
> +                        preference="security.OCSP.enabled"/>

indention is off by 2(?) spaces here. please align the attributes
Attachment #8454880 - Flags: review?(mkmelin+mozilla) → review+
Fixed indentation.
Attachment #8454880 - Attachment is obsolete: true
Attachment #8459153 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/6f4b4eb1bfcd
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 34.0
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.