1037869 - Latin1 strings: Fix remaining issues

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jan de Mooij [:jandem]]

Attachment: Patch

This patch removes the old JSString methods like chars/getChars and fixes the few remaining callers of these functions. It also removes some now-unused APIs. Some others are also unused but may be nice to keep for some embedders so I fixed them by adding an AutoCheckCannotGC argument and added separate Latin1/TwoByte versions.

Most of this is removing code:

 14 files changed, 97 insertions(+), 198 deletions(-)

Comment 1

[Terrence Cole [:terrence]]

Comment on attachment 8454919 [details] [diff] [review]
Patch

Review of attachment 8454919 [details] [diff] [review]:
-----------------------------------------------------------------

\o/ Wow, done already?

::: dom/bindings/BindingUtils.cpp
@@ +364,5 @@
>                                                TOSTRING_CLASS_RESERVED_SLOT);
>    const JSClass* clasp = static_cast<const JSClass*>(v.toPrivate());
>  
>    v = js::GetFunctionNativeReserved(callee, TOSTRING_NAME_RESERVED_SLOT);
>    JSString* jsname = static_cast<JSString*>(v.toString());

That static cast looks really funky, please remove it while you're here.

::: js/src/jsapi.h
@@ -4148,5 @@
>   * fallible context by JS_FlattenString. To catch errors, a separate opaque
>   * JSFlatString type is returned by JS_FlattenString and expected by
>   * JS_GetFlatStringChars. Note, though, that this is purely a syntactic
>   * distinction: the input and output of JS_FlattenString are the same actual
> - * GC-thing so only one needs to be rooted. If a JSString is known to be flat,

D-:

Thanks for fixing this comment!

Comment 2

[Jan de Mooij [:jandem]]

Thanks again for the quick review!

https://hg.mozilla.org/integration/mozilla-inbound/rev/0f25f3ccb7b3

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0f25f3ccb7b3