1037942 - [Keyboard] Alternative keys merged at Symbol Layout

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Raniere Silva]

Steps to Reproduce:

1. Open a app that use the keyboard.
2. Switch to symbols layout.
3. Long press the dollar symbol key.

Actual Results

There is only one alternative key that input "€ £ ¥".
	 
Expected results

Should be three alternatives keys: €, £ and ¥.

Comment 1

[Raniere Silva]

Tim, bug filed as you suggested.

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Thanks, taking.

Comment 3

[Mozilla Shepherd (This account is used for automation and doesn't receive bugmail)]

Attachment: mozilla-b2g:master PR#21654

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8455006 [details] [review]
mozilla-b2g:master PR#21654

Rudy, could you review this patch to fix a regression? Thanks!

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8455006 [details] [review]
mozilla-b2g:master PR#21654

Raniere, would you mind apply the patch locally to see if this patch works?

You can do 

curl https://github.com/mozilla-b2g/gaia/pull/21654.patch | patch -p1

to apply the patch on your work directory (be sure to stage or commit your work so they don't mix up)

Thanks!

Comment 6

[Raniere Silva]

Comment on attachment 8455006 [details] [review]
mozilla-b2g:master PR#21654

> Raniere, would you mind apply the patch locally to see if this patch works?

Works for me. Thanks.

Comment 7

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8455006 [details] [review]
mozilla-b2g:master PR#21654

r=me, thanks.

--
Raniere, thanks for filing and feedback on this issue.

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

master: https://github.com/mozilla-b2g/gaia/commit/0e6b5fec5eb508c5a94115555906261f8d809825

Comment 9

[Brogan Zumwalt [Inactive]]

Issue verified as fixed on Flame 2.1 and Flame 2.2

Device: Flame 2.1 KK (319mb) (Full Flash)
BuildID: 20141011000201
Gaia: f5d4ff60ffed8961f7d0380ada9d0facfdfd56b1
Gecko: d813d79d3eae
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Device: Flame 2.2 Master KK (319mb) (Full Flash)
BuildID: 20141011040204
Gaia: 95f580a1522ffd0f09302372b78200dab9b6f322
Gecko: 3f6a51950eb5
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

2.1 shows ¥, €, £, ¢, ₠ when long pressing $ on keyboard
2.2 shows $, €, £, ¢, ¥ when long pressing $ on keyboard

Double-checked current master to ensure verification