1029356 - Move touch event handling away from keyboard.js (Part II)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

+++ This bug was initially created as a clone of Bug #1025520 +++

+++ This bug was initially created as a clone of Bug #1023729 +++

Please read bug 1025520 comment 0. Original intention of that bug is to create a patch to move all on* functions away, but it is clear that these functions are too complex get rid of in one function. I am working on this bug to create another script/module so we can achieve that goal.

My proto-thinking right now would be creating a script called InteractionManager and/or ActiveTargetManager, which receives callbacks from UserPressManager and process these user presses into proper feedback and interaction.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

WIP https://github.com/timdream/gaia/compare/keyboard-touch-handling?expand=1

Comment 2

[Mozilla Shepherd (This account is used for automation and doesn't receive bugmail)]

Attachment: mozilla-b2g:master PR#21426

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8451418 [details] [review]
mozilla-b2g:master PR#21426

This is now ready for review except unit tests of ActiveTargetsManager.

Comment 4

[Mozilla Shepherd (This account is used for automation and doesn't receive bugmail)]

Attachment: mozilla-b2g:master PR#21473

Comment 5

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8451418 [details] [review]
mozilla-b2g:master PR#21426

Looks good to me, with only one comment below,
https://github.com/mozilla-b2g/gaia/pull/21426#discussion-diff-14635739

Thank you.

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

master: https://github.com/mozilla-b2g/gaia/commit/abde642a2b58f881f9b41ddbb0266f6f090c72d6

Comment 7

[Raniere Silva]

Tim,

maybe commit a405341e4f33e7a071c08933d72c404361630b7f introduce a bug when handling the alternative keys. Could you check it?

Steps to Reproduce:

1. Open a app that use the keyboard.
2. Switch to symbols layout.
3. Long press the dollar symbol key.

Actual Results

There is only one alternative key that input "€ £ ¥".
	 
Expected results

Should be three alternatives keys: €, £ and ¥.

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

You are right. Please file a regression bug (that is, a new bug wit Blocked link to this bug, and "regression" in the keyword field) and assign/needinfo me. I will address that next week.

Thanks for finding bugs!