Move touch event handling away from keyboard.js (Part II)

RESOLVED FIXED in 2.0 S6 (18july)

Status

Firefox OS
Gaia::Keyboard
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: timdream, Assigned: timdream)

Tracking

unspecified
2.0 S6 (18july)
x86
Mac OS X
Dependency tree / graph

Firefox Tracking Flags

(feature-b2g:2.1)

Details

(Whiteboard: [p=8])

Attachments

(1 attachment, 1 obsolete attachment)

+++ This bug was initially created as a clone of Bug #1025520 +++

+++ This bug was initially created as a clone of Bug #1023729 +++

Please read bug 1025520 comment 0. Original intention of that bug is to create a patch to move all on* functions away, but it is clear that these functions are too complex get rid of in one function. I am working on this bug to create another script/module so we can achieve that goal.

My proto-thinking right now would be creating a script called InteractionManager and/or ActiveTargetManager, which receives callbacks from UserPressManager and process these user presses into proper feedback and interaction.
Comment on attachment 8451418 [details] [review]
mozilla-b2g:master PR#21426

This is now ready for review except unit tests of ActiveTargetsManager.
Attachment #8451418 - Flags: review?(rlu)
Whiteboard: [p=5] → [p=8]
Target Milestone: 2.0 S5 (4july) → 2.0 S6 (18july)
Attachment #8452098 - Attachment is obsolete: true
Comment on attachment 8451418 [details] [review]
mozilla-b2g:master PR#21426

Looks good to me, with only one comment below,
https://github.com/mozilla-b2g/gaia/pull/21426#discussion-diff-14635739

Thank you.
Attachment #8451418 - Flags: review?(rlu) → review+
master: https://github.com/mozilla-b2g/gaia/commit/abde642a2b58f881f9b41ddbb0266f6f090c72d6
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED

Comment 7

4 years ago
Tim,

maybe commit a405341e4f33e7a071c08933d72c404361630b7f introduce a bug when handling the alternative keys. Could you check it?

Steps to Reproduce:

1. Open a app that use the keyboard.
2. Switch to symbols layout.
3. Long press the dollar symbol key.

Actual Results

There is only one alternative key that input "€ £ ¥".
	 
Expected results

Should be three alternatives keys: €, £ and ¥.
Flags: needinfo?(timdream)
You are right. Please file a regression bug (that is, a new bug wit Blocked link to this bug, and "regression" in the keyword field) and assign/needinfo me. I will address that next week.

Thanks for finding bugs!
Flags: needinfo?(timdream)

Updated

4 years ago
Depends on: 1037942

Updated

4 years ago
Blocks: 1011482

Updated

4 years ago
No longer blocks: 1011482

Updated

4 years ago
feature-b2g: --- → 2.1
Depends on: 1088474
You need to log in before you can comment on or make changes to this bug.