1038232 - Allow users to clear search history

Status: RESOLVED DUPLICATE of bug 1022105

(Firefox for Android Graveyard :: Search Activity, defect, P1)

Description

[Eric Edens [:eedens]]

We collect search history for the search activity. Users should be able to clear this in the same way they clear other private info (browsing history, cache, etc).

The "Clear private data" UI shows two places this might make sense -- "Browsing history" and "Form & search history". So we'll need to decide which will trigger clearing the search history.

Content provider: https://lxr.mozilla.org/mozilla-central/source/mobile/android/base/db/SearchHistoryProvider.java
Unit tests and examples: https://lxr.mozilla.org/mozilla-central/source/mobile/android/base/tests/testSearchHistoryProvider.java

Comment 2

[:Margaret Leibovic]

As dria mentioned in bug 1038912, it would also be nice to give users a more fine-grained tool to clear individual search terms.

This may be out of the scope of this bug, but it's something to consider. Maybe a contextual action on search history items that appear?

Comment 3

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: prev_suggestions_dismiss.png

I'd think that the 3-dot menu along the bottom would be a good place to put this (at least for now).

We could probably use the same styling as the current 3-dot menu on Firefox for Android but (as the gravy on top) I'd like to see if we can show an animation before actually clearing all items. 

This would be a simple slide that shows the 'x' by sliding over all cards before clearing them. This will probably help the discover-ability of 'per item deleting' while also providing a better experience overall.

Thoughts?

Comment 4

[Eric Edens [:eedens]]

Merging this with bug 1022105 which adds the ability to clear search history from a settings menu.  For clearing *individual* history items, see bug 1030896.