1038288 - Implement the updated InContent Preferences Design

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Richard Marti (:Paenglab)]

Bug for styling the updated InContent Preferences Design. For reference see attachment 8439538 [details].

Comment 1

[Richard Marti (:Paenglab)]

Attachment: updateInContentStyles.patch

I removed the header icons and the 60px margin on the left like the mockup shows. I made the connected textbox and button generic to apply on all such elements (for example on Connections dialog in Advanced pane, when it land) like Chameleon wants it.

I also improved a little bit the margins of the in-content dialogs title and actionButtons but the fine finish of them will be done in bug 1036090.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8455616 [details] [diff] [review]
updateInContentStyles.patch

Review of attachment 8455616 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Tested it on Windows7 Aero.

::: browser/themes/shared/incontentprefs/preferences.css
@@ +610,5 @@
>  .fileFieldLabel {
>    -moz-margin-start: -26px;
>    -moz-padding-start: 36px;
>  }
> + 

nit, trailing space

Comment 3

[Richard Marti (:Paenglab)]

Attachment: Patch for check-in

Removed trailing space.

Comment 4

[Richard Marti (:Paenglab)]

Try: https://tbpl.mozilla.org/?tree=Try&rev=8bc4b0831e74

Comment 5

[Carsten Book [:Tomcat]]

Hi,

seems this patch didn't apply cleanly :

applying updateInContentStyles.patch
patching file browser/themes/shared/incontentprefs/preferences.css
Hunk #8 FAILED at 809
1 out of 8 hunks FAILED -- saving rejects to file browser/themes/shared/incontentprefs/preferences.css.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh updateInContentStyles.patch

could you look into this and resolve the conflict/maybe rebase against a current tree ? thanks!

Comment 6

[Richard Marti (:Paenglab)]

Attachment: patch for check-in

Updated after bug 1035625 landing.

Comment 7

[Carsten Book [:Tomcat]]

cool, thanks, did now the checkin!

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/d5e892913147

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d5e892913147