Closed Bug 1038494 Opened 5 years ago Closed 5 years ago

Test case for track interfaces when consuming a MediaStream

Categories

(Core :: Audio/Video, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: shelly, Assigned: shelly)

References

Details

(Whiteboard: [FT:Stream3])

Attachments

(1 file, 2 obsolete files)

The current test case (test_mediatrack_events_and_consuming_ms.html) is kindda fragile, so re write it.
Though consuming a media stream won't meet the case where playback has ended before events are fired, I think it would be better to make the two test cases as identical as possible, since they are testing the same scenario but consuming different resources. I also break out the part of testing event identities, mixing two testing goal into one test seem not good.
Attachment #8456049 - Flags: review?(roc)
Blocks: 1026351
Whiteboard: [FT:Stream3]
Blocks: 1035482
Comment on attachment 8456049 [details] [diff] [review]
Rewrite test cases of track interfaces when consuming a media stream

Review of attachment 8456049 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry about the delay

::: content/media/test/test_mediatrack_events.html
@@ +18,5 @@
> +            'HTMLMediaElement::AudioTracks() property should be available.');
> +      isnot(element.videoTracks, undefined,
> +            'HTMLMediaElement::VideoTracks() property should be available.');
> +
> +      function verify_event(e, type) {

verifyEvent
Attachment #8456049 - Flags: review?(roc) → review-
This patch has updated the function name to verifyEvent.
Thanks!
Attachment #8456049 - Attachment is obsolete: true
Attachment #8459427 - Flags: review?(roc)
https://hg.mozilla.org/mozilla-central/rev/dec3449b055e
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch New fix for this test case (obsolete) — Splinter Review
Comment on attachment 8465279 [details] [diff] [review]
New fix for this test case

Review of attachment 8465279 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/test/test_mediatrack_consuming_mediastream.html
@@ -52,2 @@
>            is(element.audioTracks.length, 0, 'The length of audioTracks should be 0.');
> -          is(videoOnremovetrack, 1, 'Calls of onremovetrack on videoTracks should be 1.');

I think it should be fine to remove the check of onremovetrack on video element, because 1. It should really be checked at the onended event handler of MediaStream or the onended event handler of MediaStreamTrack, and we implement them neither, and 2. We are still checking the length of video.audioTracks and video.videoTracks.
Try server result with failing platform:
(Android 2.3 Emulator try opt test mochitest-4 )
https://tbpl.mozilla.org/?tree=Try&rev=0bc5c4782685

(b2g_emulator_vm try opt test mochitest-3)
https://tbpl.mozilla.org/?tree=Try&rev=72b4bd387fe4
Move the fix to bug 1047307.
Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
Attachment #8465279 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.