1038616 - [Dialer] Busy tone not playing

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: screenshot-busy_tone_overlay.png

STR:
1. Make a call using the DuT to any number.
2. Hang up the call on the called device.

EXPECTED:
3. The busy tone plays.

OBSERVED:
3. No tone or sound is played.

The busy tone overlay is properly shown though as can be seen in the included attachment.

Comment 1

[Germán Toro del Valle (:gtorodelvalle)]

The DuT is a Hamachi using Gecko-73bd274.Gaia-16ce067 (this is master :) )

Comment 2

[Germán Toro del Valle (:gtorodelvalle)]

Wow! I just noticed that the busy tone is played (I mean it can be heard :p) after rebooting the device but only after the first busy line call. From that point on, the busy tone is not heard although supposedly played :-O

On the other hand, I checked that when the busy tone is played the channel is "normal". Just in case it helps :)

Etienne, could you provide us with some clue or someone to contact? :) No error is displayed on the console (related to this :p).

Comment 3

[Germán Toro del Valle (:gtorodelvalle)]

It does reproduces in v2.0 (Gecko-cf6d91d.Gaia-f2509d2). In fact, in v2.0 the sound cannot be heard not even when calling a busy line after flashing or rebooting the device :(

Comment 4

[Beatriz Rodríguez [:brg]]

this is a cert blocker in 2.0. Nominating accordingly.

Comment 5

[Etienne Segonzac (:etienne)]

(In reply to Germán Toro del Valle from comment #2)
> Wow! I just noticed that the busy tone is played (I mean it can be heard :p)
> after rebooting the device but only after the first busy line call. From
> that point on, the busy tone is not heard although supposedly played :-O
> 
> On the other hand, I checked that when the busy tone is played the channel
> is "normal". Just in case it helps :)
> 
> Etienne, could you provide us with some clue or someone to contact? :) No
> error is displayed on the console (related to this :p).

Yeah we probably want to play it on the telephony channel, hope it wont cause issue with the audio competing work...

Comment 6

[Germán Toro del Valle (:gtorodelvalle)]

Hi José Antonio, do you envision any issue which we may not be considering here regarding using the 'telephony' channel? Thanks!

Comment 7

[David Garcia [:davidg][retired]]

Attachment: github PR

Comment 8

[Etienne Segonzac (:etienne)]

Comment on attachment 8457946 [details] [review]
github PR

Left some comments about the tests, please ask me for a last quick review round once those are addressed.

Comment 9

[Etienne Segonzac (:etienne)]

Comment on attachment 8457946 [details] [review]
github PR

Thanks!

Comment 10

[David Garcia [:davidg][retired]]

Thanks Etienne.

Checkin needed

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/99517c286d6823e87df7b0584d793f3fb2452355

Comment 12

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/9b458f1256c4318f1e999aaca5b98f0ed3994b32

Comment 13

[Paladin]

Attachment: Verify_video.3gp

This issue has been verified successfully on Flame 2.0,2.1

See attachment: Verify_video.3gp
Reproducing rate: 0/5
flame 2.0 version:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141201000201
Version         32.0
FLame2.1 build:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141201001201
Version         34.0