1038822 - [email/UI] 2.0 Visual Refresh follow-up: hook up :active/pressed states to compose "add contact" and "remove attachment" buttons/icons

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Andrew Sutherland [:asuth] (he/him)]

While reviewing bug 1035716 (to remove some icons, which was then accidentally landed) I noticed that we had (now removed) unused pressed-state icons for the add recipient button and the remove attachment button.

It makes sense that there probably should be active-states for these buttons, so I'm opening this bug.  NI'ng Fang Shih to confirm as to whether this should be done or not (and whether we should re-add the removed icons).  If we should just be using magic CSS, that also works.  If we don't want :active states at all, it's okay to just directly resolve this bug as invalid.  Thanks!

Comment 1

[James Burke [:jrburke]]

My understanding is that for 2.0 we are moving away from the pressed states of icons, so I had removed some before. Although in that case, we could use this bug to remove the pressed state icons we have for:

* arrow up/down in folder_picker menu overlay for switching accounts, but does this also mean changing the active color for the text away from white?
* The folder icons that show up in the folder list. Same issue with the text changing to white on selection.
* the settings icon on that overlay too. No text around it so not complicated by any text changing color.

Comment 2

[Fang Shih [:fang]]

I think for the add recipient button, I would like to have pressed-state if we can, Since MMS has pressed-state for add recipient button. For the pressed-state on drawer. I would like to keep the way it is right now. Thanks!

Comment 3

[BMO Automation]

Firefox OS is not being worked on