[Email] - remove unused images

RESOLVED FIXED in Firefox OS v2.1

Status

Firefox OS
Gaia::E-Mail
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: ivanovpavel, Assigned: ivanovpavel)

Tracking

unspecified
2.0 S6 (18july)
x86
Mac OS X

Firefox Tracking Flags

(b2g-v2.1 fixed)

Details

Attachments

(1 attachment)

We need to check following images:

apps/email/style/images/icons/actionicon_email_addrecipient_press.png
apps/email/style/images/icons/icon_outbox_pending.png
apps/email/style/images/icons/icon_outbox_sending.png
apps/email/style/images/icons/remove_message.png
apps/email/style/images/icons/reply-all.png
apps/email/style/images/icons/search.png
apps/email/style/images/icons/settings.png
apps/email/style/images/icons/undo.png

??? - we need to double check this
Created attachment 8456068 [details] [review]
patch for Gaia/master

Hey James,
can you check this one ... I landed it by mistake :( hope that everything will be OK
Attachment #8456068 - Flags: review?(jrburke)
Comment on attachment 8456068 [details] [review]
patch for Gaia/master

James is on vacation so I took a look at what's being removed/was removed.  Most of these seem like they were fine to remove.  The ones that don't need CSS work to be hooked up, so I'll file a spin-off bug and we can re-add those images there.  (I believe that backing out the accidental landing would bloat the repository by re-adding all the removed images, better to just re-add them back when needed.)  This is probably the right call anyways since we have an unused image linter coming.

- style/images/icons/actionicon_email_addrecipient_press.png (1x), @1.5x, @2x, @2.25x

Maybe should not have been purged.  These are pretty clearly the :active variants of actionicon_email_addrecipient.png and friends, they just didn't get hooked up.  Filing a bug to fix the :active stuff.

- style/images/icons/remove_message.png (1x), @1.5x, @2x, @2.25x

Maybe should not have been purged.  This was added in the visual refresh update bug 950208.  It looks like these are supposed to be the _press variants of actionicon_email_removeattachment.png.  I'm putting these in the bug too, and we should improve the names when doing so.


- style/images/icons/reply-all.png (1x), @1.5x, @2x, @2.25x

Yes, good to purge, although there's a weird situation here.  Bug 918303 added the image; it looks like there was some confusion since the email app has been sourcing its reply-all icon from the shared area.  Namely we use:
  background-image: url("../shared/style/headers/images/icons/reply_all.png");

We are overhauling reply stuff in bug 1023656 again, so I'm going to comment there referencing this removed image and the shared image so we can try and make things better there if it is really only used by the email app.


- style/images/icons/search.png (1x), @1.5x, @2x, @2.25x

Yes, good to purge.  Bug 940132 removed the search button but left the image around.


- style/images/icons/settings.png (1x), @1.5x, @2x, @2.25x

Yes, out of date/mooted.  We are currently using style/images/icons/settings_icon.png and settings_icon_press.png.  These seem to have a different post-refresh style, and were indeed added in bug 940132 for the drawer refactoring.


- style/images/icons/undo.png (1x), @1.5x, @2x, @2.25x

Yes, unused, good to purge.  I don't think it was ever used, although it was probably speculatively for the toasts.  But we have a new, different set of undo/redo icons on bug 1021981 for implementing that, so this can stay gone.
Attachment #8456068 - Flags: review?(jrburke) → review+
landed in gaia/master:
https://github.com/mozilla-b2g/gaia/pull/21747
https://github.com/mozilla-b2g/gaia/commit/2276ee455bb471b65bed89d3f402beb598e47835
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-b2g-v2.1: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S6 (18july)
See Also: → bug 1038822
You need to log in before you can comment on or make changes to this bug.