Closed
Bug 1039004
Opened 11 years ago
Closed 10 years ago
Port |Bug 633773 - Use Google's HTTPS search by default|, |Bug 958883 - Use HTTPS for Yahoo searches| and search plugin parts of |Bug 959576 - Create a component to get the list of priority domains| to SeaMonkey
Categories
(SeaMonkey :: Search, defect)
SeaMonkey
Search
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.30
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
References
Details
(Keywords: productization)
Attachments
(1 file, 1 obsolete file)
7.50 KB,
patch
|
neil
:
review+
iannbugzilla
:
feedback+
|
Details | Diff | Splinter Review |
Yahoo and Google search over HTTPS now work in a useful way, so we should do the same switch as Firefox. We also need to match the search plugin changes from Bug 959576.
Attachment #8456509 -
Flags: feedback?(mconnor)
Comment 1•11 years ago
|
||
+<Url type="application/x-suggestions+json" method="GET" template="https://www.google.com/complete/search?output=firefox&client=firefox&hl={moz:locale}&q={searchTerms}"/>
|client=firefox| Does this mean that monetization goes to Mozilla instead of SeaMonkey?
Comment 2•11 years ago
|
||
Comment on attachment 8456509 [details] [diff] [review]
SM searchplugin changes
To answer Philipp's question: No. There's no monetization of search suggestion, just via results. client= in that context returns different formats. i.e. "toolbar" returns XML. If it was related to revenue, it'd have to be a conditional.
Other feedback:
* You may want to change appId in the Yahoo plugin to something distinct. It's not a big deal though.
* I'd recommend switching the suggestions URL in the Google plugin to use Params like the "text/html" version. It's really much more readable that way, which is why the yahoo plugin changed when we updated it recently.
*
Attachment #8456509 -
Flags: feedback?(mconnor) → feedback+
Patch now:
* Ports Bug 557665, and updates the <SearchForm> lines for each search plugin
* Ports Bug 557890, and updates the Google search plugin suggestion URLs
* A distinct appID for the yahoo search plugin
* The suggestions URL in the Google search plugin now uses Params
Carrying forward f+
Assignee: nobody → iann_bugzilla
Attachment #8456509 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8459318 -
Flags: review?(neil)
Attachment #8459318 -
Flags: feedback+
Updated•11 years ago
|
Attachment #8459318 -
Flags: review?(neil) → review+
Comment on attachment 8459318 [details] [diff] [review]
Revised SM searchplugin changes [Checked in: Comment 4]
Checked in with one attribute per line in the changed sections:
https://hg.mozilla.org/comm-central/rev/4ba4f87fef61
Attachment #8459318 -
Attachment description: Revised SM searchplugin changes → Revised SM searchplugin changes [Checked in: Comment 4]
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.30
You need to log in
before you can comment on or make changes to this bug.
Description
•