Update Google search plugin suggestion URLs

RESOLVED FIXED in Firefox 14

Status

()

Firefox
Search
RESOLVED FIXED
8 years ago
3 years ago

People

(Reporter: Gavin, Assigned: MattN)

Tracking

Trunk
Firefox 14
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

See bug 511017 comment 17, and subsequent comments. These changes will depend on the patch in bug 557665.

There's no need to delay these changes on the changes in bug 511017, so I'm splitting it out.
Created attachment 437651 [details] [diff] [review]
patch

This is a patch on top of the patch for bug 557665.

It makes the following changes:
- changes the suggest URL from suggestqueries.google.com to clients1.google.com
- removes the "hl" parameter from the suggest URL
- adds the "client" parameter to the <SearchForm> URL (the URL used for empty location bar searches). This URL behaves the same way as it does in the normal search URL (client="firefox-a" for builds that ship Google as the default selected engine, client="firefox" otherwise)
- adds the "rls" parameter to the <SearchForm> URL. It also behaves the same way as it does in the normal search URL.

This means that for official Firefox en-US builds (as shipped by MoCo), the URLs used will be:

Suggest:
http://clients1.google.com/complete/search?client=firefox&q={searchTerms}
SearchForm:
http://www.google.com/firefox?client=firefox-a&rls=org.mozilla:en-US:official
Search:
http://www.google.com/search?q={searchTerms}&ie=utf-8&oe=utf-8&aq=t&rls=org.mozilla:en-US:official&client=firefox-a

(The normal search URL is unchanged by this patch, I just included it for completeness.)
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED

Comment 2

7 years ago
+Trystan

Hey guys, any update on this bug? Let us know how we can help.
It's currently blocked on bug 557665 - will try to get some movement there.

Comment 4

7 years ago
Thanks Gavin!
No progress on bug 557665 yet, but I just realized that that shouldn't actually stop us from making the first two changes:

- change the suggest URL from suggestqueries.google.com to clients1.google.com
- remove the "hl" parameter from the suggest URL

Is this something we should try to push into Firefox 4?
Created attachment 602209 [details] [diff] [review]
v.1 patch for suggest URL w/o dependency

(Quoting Gavin Sharp (use gavin@gavinsharp.com for email) from comment #5)
> No progress on bug 557665 yet, but I just realized that that shouldn't
> actually stop us from making the first two changes:
> 
> - change the suggest URL from suggestqueries.google.com to
> clients1.google.com
> - remove the "hl" parameter from the suggest URL

I made the above two changes plus removed the "output" parameter since it "is deprecated in favor of just the client param" according to bug 511017 comment 17.
Assignee: gavin.sharp → mnoorenberghe+bmo
Attachment #602209 - Flags: review?(gavin.sharp)
Comment on attachment 602209 [details] [diff] [review]
v.1 patch for suggest URL w/o dependency

Looks good to me. We'll need to run this by kev for sign-off before landing it.
Attachment #602209 - Flags: review?(gavin.sharp) → review+
Attachment #602209 - Flags: review?(kev)

Comment 8

6 years ago
For the suggest URL, you should use https://www.google.com instead of clients1.google.com.  It should be fine to use the same top-level domain for search suggest and actual search queries (with different query strings, of course).
Sid/Mike, should the hl and output parameters still be removed?
Created attachment 606817 [details] [diff] [review]
v.1 patch for suggest params rebased with HTTPS

Rebased on top of bug 633773 and incorporating comment 8.

Kev/Sid, it would be nice for localizers if we can do this change with bug 633773 if it's still wanted.
Attachment #602209 - Attachment is obsolete: true
Attachment #606817 - Flags: review?(sstamm)
Attachment #606817 - Flags: review?(kev)
Attachment #602209 - Flags: review?(kev)

Comment 11

6 years ago
Hey guys, the Google search team is ok with Firefox dropping the hl parameter from the suggest URL.  Let me know if you have any questions.
Comment on attachment 606817 [details] [diff] [review]
v.1 patch for suggest params rebased with HTTPS

Let's go ahead and land this.
Attachment #606817 - Flags: review?(sstamm)
Attachment #606817 - Flags: review?(kev)
Attachment #606817 - Flags: review+
(In reply to Mike Graboski from comment #11)
> Hey guys, the Google search team is ok with Firefox dropping the hl
> parameter from the suggest URL.  Let me know if you have any questions.

Note that this also removes the "output" parameter as requested before (see comment 6).

This patch was only for browser/ but I think this change is probably applicable to all Google search plugins so I'll make a patch including the others.
Created attachment 610671 [details] [diff] [review]
mobile patch for removed suggest params

Mobile equivalent
Attachment #437651 - Attachment is obsolete: true
Attachment #610671 - Flags: review?(mark.finkle)
No longer depends on: 557665
Summary: Update Google search plugin URLs → Update Google search plugin suggestion URLs
Comment on attachment 610671 [details] [diff] [review]
mobile patch for removed suggest params

thanks
Attachment #610671 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/integration/fx-team/rev/a78d2f8055e7
Target Milestone: --- → Firefox 14
https://hg.mozilla.org/mozilla-central/rev/a78d2f8055e7
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

3 years ago
Blocks: 1039004

Updated

3 years ago
Blocks: 1039003
You need to log in before you can comment on or make changes to this bug.