1039019 - Set MOZ_DISABLE_NONLOCAL_CONNECTIONS for opt B2G mochitests

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Webapps update trips this at startup, but there's probably more lingering.

Comment 1

[Ed Morley [:emorley]]

I'm presuming you found this whilst fixing bug 1038943? The env not being passed through explains why this wasn't caught as part of bug 995417 - good spot :-)

My try run from bug 1026958:
https://tbpl.mozilla.org/?tree=Try&rev=11c7efe3e34a

Shows the following external connections...

b2g_emulator_vm try opt test mochitest-1:
marketplace.allizom.org (63.245.217.111)

b2g_emulator_vm try opt test {crashtest,reftest}:
marketplace.firefox.com (63.245.216.131)

b2g_emulator_vm try opt test {mochitest,reftest,marionette-webapi,gaia-ui-test,gaia-unit}:
inapp-pay-test.paas.allizom.org (63.245.215.73)

b2g_emulator_vm try debug test {mochitest-debug,xpcshell}:
dynamicua.cdn.mozilla.net (23.203.212.61)

Comment 2

[Ed Morley [:emorley]]

Try push to see what breaks:
https://tbpl.mozilla.org/?tree=Try&rev=4152ad1ae14d

Comment 3

[Ed Morley [:emorley]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=45336486&tree=Try
b2g_emulator_vm try opt test mochitest-6
2.pool.ntp.org (198.55.111.50)

https://tbpl.mozilla.org/php/getParsedLog.php?id=45333715&tree=Try
b2g_emulator_vm try opt test mochitest-7
3.pool.ntp.org (198.60.22.240)

https://tbpl.mozilla.org/php/getParsedLog.php?id=45335513&tree=Try
https://tbpl.mozilla.org/php/getParsedLog.php?id=45334433&tree=Try
https://tbpl.mozilla.org/php/getParsedLog.php?id=45336183&tree=Try
https://tbpl.mozilla.org/php/getParsedLog.php?id=45333253&tree=Try
b2g_emulator_vm try debug test mochitest-debug-{1-15}
inapp-pay-test.paas.allizom.org (63.245.215.73)

Comment 4

[Ed Morley [:emorley]]

Attachment: Set MOZ_DISABLE_NONLOCAL_CONNECTIONS for opt B2G mochitests

Opt B2G mochitests were almost green, apart from bug 1052016:
https://tbpl.mozilla.org/?rev=4152ad1ae14d&tree=Try

My patch in bug 1052016 has a green try run (and is awaiting review):
https://tbpl.mozilla.org/?tree=Try&rev=67cdda9e6b14

Once that lands, lets at least protect ourselves from regressions in the opt tests, whilst we sort out bug 1053163 (and possibly more) affecting debug.

Comment 5

[Ed Morley [:emorley]]

Full B2G try run with both the patch here and the patch from bug 1052016, just to check none of the debug tests dislike bug 1052016 on it's own:
https://tbpl.mozilla.org/?tree=Try&rev=846ea8c7a49c

Comment 6

[Nathan Froyd [:froydnj]]

Comment on attachment 8472299 [details] [diff] [review]
Set MOZ_DISABLE_NONLOCAL_CONNECTIONS for opt B2G mochitests

Review of attachment 8472299 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/mochitest/runtestsb2g.py
@@ +167,5 @@
>              # empty env.
>              self.browserEnv = self.buildBrowserEnv(options, env={})
>  
> +            # B2G emulator debug tests still make external connections, so don't
> +            # pass MOZ_DISABLE_NONLOCAL_CONNECTIONS to them for now (bug 1039019).

I guess you're leaving the original bug reference here, rather than changing it to bug 1053163, because you're going to land this patch but leave this bug open until bug 1053163 lands?  If that's a correct assumption, this is fine; otherwise, I think it'd make more sense to change the bug number in the comment.

Comment 7

[Ed Morley [:emorley]]

(In reply to Nathan Froyd (:froydnj) from comment #6)
> I guess you're leaving the original bug reference here, rather than changing
> it to bug 1053163, because you're going to land this patch but leave this
> bug open until bug 1053163 lands?

Yeah, I know there's at least one more (dynamicua.cdn.mozilla.net; https://tbpl.mozilla.org/php/getParsedLog.php?id=45847614&tree=Try#error4) and I'm going to leave this open and hang them off of this bug.

https://hg.mozilla.org/integration/mozilla-inbound/rev/4bdf267a1b90

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4bdf267a1b90

Comment 9

[Ryan VanderMeulen [:RyanVM]]

There's too many dependencies to easily backport this to the various B2G release branches, but I intend to at least uplift the dependencies where possible.

Comment 10

[Ed Morley [:emorley]]

Broken the debug parts out to bug 1061703 to clean up my bugzilla-todos lists.