1053163 - B2G emulator debug mochitests and Mulet reftests attempt to connect to inapp-pay-test.paas.allizom.org

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Ed Morley [:emorley]]

For tests jobs in automation to meet the visibility policy (https://wiki.mozilla.org/Sheriffing/Job_Visibility_Policy), they must not make external connections. Bug 1039019 is trying to enable MOZ_DISABLE_NONLOCAL_CONNECTIONS for B2G mochitests (carrying on the work started in bug 995417), however I'm seeing the following attempted connections on debug mochitest B2G emulator jobs (note: opt are fine):

In: b2g_emulator_vm try debug test mochitest-debug-{1-15}
08:14:36     INFO -  08-06 15:13:02.143 I/Gecko   (  677): FATAL ERROR: Non-local network connections are disabled and a connection attempt to inapp-pay-test.paas.allizom.org (63.245.215.73) was made.
08:14:36     INFO -  08-06 15:13:02.143 I/Gecko   (  677): You should only access hostnames available via the test networking proxy (if running mochitests) or from a test-specific httpd.js server (if running xpcshell tests). Browser services should be disabled or redirected to a local server.

eg:
https://tbpl.mozilla.org/php/getParsedLog.php?id=45335513&tree=Try
https://tbpl.mozilla.org/php/getParsedLog.php?id=45334433&tree=Try
https://tbpl.mozilla.org/php/getParsedLog.php?id=45336183&tree=Try
https://tbpl.mozilla.org/php/getParsedLog.php?id=45333253&tree=Try

Full try run is at:
https://tbpl.mozilla.org/?rev=4152ad1ae14d&tree=Try

MXR searches:
http://mxr.mozilla.org/mozilla-central/search?string=inapp-pay-test
http://mxr.mozilla.org/gaia/search?string=inapp-pay-test

Found:

http://mxr.mozilla.org/gaia/source/build/test/integration/helper.js#59
>     line 59 -- webapp.origin.indexOf('inapp-pay-test.paas.allizom.org') !== -1 ?

http://mxr.mozilla.org/gaia/source/dev_apps/in_app_pay_test/metadata.json#3
>     line 3 -- "origin": "http://inapp-pay-test.paas.allizom.org",
>     line 4 -- "manifestURL": "http://inapp-pay-test.paas.allizom.org/manifest.webapp",

http://mxr.mozilla.org/gaia/source/dev_apps/uitest/js/API/pay.js#13
>     line 13 -- "postbackURL": "https://inapp-pay-test.paas.allizom.org/mozpay/postback",
>     line 15 -- "chargebackURL": "https://inapp-pay-test.paas.allizom.org/mozpay/chargeback",

Both ui-test and in_app_pay_test are in:
http://mxr.mozilla.org/gaia/source/build/config/phone/apps-engineering.list

Which I guess is used only for debug builds hence opt not hitting this issue?

Comment 1

[Jonathan Griffin (:jgriffin)]

We're hitting this when attempting to set up reftests in Mulet as well.  Gregor, do you know who could look into figuring out how we could disable this?

Comment 2

[Gregor Wagner [:gwagner]]

Fernando, any idea?

Comment 3

[Armen [:armenzg]]

Any updates?

FTR, after the next reconfig of the releng masters you should be able to hit this issue by pushing to try with this patch [1] and this syntax:
try: -b o -p linux64-mulet -u reftest -t none

[1]
https://bugzilla.mozilla.org/attachment.cgi?id=8497650

Comment 4

[Fernando Jiménez Moreno [:ferjm]]

The try logs pasted in the description are gone. I just pushed to try as suggested in comment 3 https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=2079e9fdb1c5 .

Anyway, I have no idea why we are trying to access inapp-pay-test.paas.allizom.org on mochitests. In fact, we have no mochitests for payments, only xpcshell tests. The inapp-pay-test app was added to allow manual testing on gaia dev builds. IIRC is not used on automatic tests.

Comment 5

[Fernando Jiménez Moreno [:ferjm]]

(In reply to Armen Zambrano - Automation & Tools Engineer (:armenzg) from comment #3)
> Any updates?
> 
> FTR, after the next reconfig of the releng masters you should be able to hit
> this issue by pushing to try with this patch [1] and this syntax:
> try: -b o -p linux64-mulet -u reftest -t none
> 
> [1]
> https://bugzilla.mozilla.org/attachment.cgi?id=8497650

The try push I made didn't run the tests with that syntax.

Comment 6

[Jonathan Griffin (:jgriffin)]

I don't think the access has anything to do with the actual tests being run.  I suspect it happens at startup, possibly depending on Gaia prefs/settings.  Is there something loaded at startup that would cause this to happen?

Comment 7

[Armen [:armenzg]]

The reconfig of the masters had not yet happened. [1]
It should work now.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1043699#c63

Comment 8

[Armen [:armenzg]]

(In reply to Armen Zambrano - Automation & Tools Engineer (:armenzg) from comment #7)
> The reconfig of the masters had not yet happened. [1]
> It should work now.
> 
> [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1043699#c63

You can see again the log in here:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=68a96b436f39
http://ftp.mozilla.org/pub/mozilla.org/b2g/try-builds/[e-mail]-68a96b436f39/try-linux64-mulet/try_ubuntu64_vm-mulet_test-reftest-bm68-tests1-linux64-build7.txt.gz

Comment 9

[Fernando Jiménez Moreno [:ferjm]]

(In reply to Jonathan Griffin (:jgriffin) from comment #6)
> I don't think the access has anything to do with the actual tests being run.
> I suspect it happens at startup, possibly depending on Gaia prefs/settings. 
> Is there something loaded at startup that would cause this to happen?

It seems that what we do is a GET request to fetch the app icon (http://inapp-pay-test.paas.allizom.org/img/out-128.png) because this app is a remotely hosted app. We could move this app from hosted to package or try adding appcache to prefetch the icon. I am not sure if Gaia is currently prefetching appcache during the build process though.

Comment 10

[Fernando Jiménez Moreno [:ferjm]]

Or we could also get rid of the icon...

Comment 11

[[:fabrice] Fabrice Desré]

(In reply to Fernando Jiménez Moreno [:ferjm] from comment #10)
> Or we could also get rid of the icon...

I would just do that. Simpl, brutal but efficient :P

Comment 12

[Fernando Jiménez Moreno [:ferjm]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25035/files

This patch removes the icons from the metada but we still need to remove them from http://inapp-pay-test.paas.allizom.org/ that I cannot access.

Comment 13

[Fernando Jiménez Moreno [:ferjm]]

Kumar, could you take care of removing the icons from http://inapp-pay-test.paas.allizom.org or ask someone with access to that server to do it, please?

Comment 14

[Fernando Jiménez Moreno [:ferjm]]

https://github.com/mozilla-b2g/gaia/commit/9c58445548bce2d610dd41829dcee24e553496ca

I'll leave it open until Kumar removes the icons from the remote hosted app.

Comment 15

[Kumar McMillan [:kumar]]

Hi all. I'm out of the office but I can look at this when I'm back. If you want to fix up the app, the source is here: https://github.com/kumar303/inapp-pay-test Maybe switching it to a packaged app is best? However, it still needs a server to sign JWTs so I'm not sure why mochitests are even running this tester app in the first place. In other words, the app needs to hit a remote server to function.

Comment 16

[Fernando Jiménez Moreno [:ferjm]]

(In reply to Kumar McMillan [:kumar] (needinfo for quickness) (on PTO until Nov 10) from comment #15)
> Hi all. I'm out of the office but I can look at this when I'm back. If you
> want to fix up the app, the source is here:
> https://github.com/kumar303/inapp-pay-test Maybe switching it to a packaged
> app is best? However, it still needs a server to sign JWTs so I'm not sure
> why mochitests are even running this tester app in the first place. In other
> words, the app needs to hit a remote server to function.

Thanks Kumar. We are not using this app within the mochitest run, but because it is a hosted app we are trying to fetch its icon from the remote server. Removing the icons from the app manifest should solve the issue.

Comment 17

[Armen [:armenzg]]

Thanks a lot for helping with this.

Does anyone know if we're done in here? If any follow up work is required?

Comment 18

[Fernando Jiménez Moreno [:ferjm]]

We need someone with access to the server hosting http://inapp-pay-test.paas.allizom.org to remove the icons from there. Kumar is returning from PTO on Nov 10th so hopefully he will be able to do it then.

Comment 19

[Kumar McMillan [:kumar]]

I'm back! Could someone maybe ping me (kumar) on IRC about this? I'm not clear as to why I need to remove the icons from the manifest. If I remove the icons then the app will not validate when we submit it to the Marketplace (as we do for periodic testing) and also it would look generic when installed on device. Or am I misinterpreting the icon removal request?

Comment 20

[Armen [:armenzg]]

From what I understand we don't actually need to remove the icon in itself but trying to retrieve it which was accomplished in https://github.com/mozilla-b2g/gaia/pull/25035/files

As far as I know we're done in here.

Reopen if I got it wrong.